SNOW-1720855: clean up multithreading changes after rollout

[sfc-gh-aalam]

1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

   Fixes SNOW-1720855

2. Fill out the following pre-review checklist:

   • I am adding a new automated test(s) to verify correctness of my new code
     • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
   • I am adding new logging messages
   • I am adding a new telemetry message
   • I am adding new credentials
   • I am adding a new dependency
   • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
   • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines

3. Please describe how your code solves the related issue.

   Clean-up code by removing param protection and remove tests that test the case when thread-safe session is disabled.

[sfc-gh-aalam]

https://github.com/snowflakedb/snowpark-python/actions/runs/12587632345 daily precommit

[github-actions]

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

[github-actions]

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

[github-actions]

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

[github-actions]

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

[sfc-gh-jrose]

so clean

[github-actions]

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

[sfc-gh-aling]

do we need to clean up this parameter in the backend?

[github-actions]

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

[sfc-gh-helmeleegy]

This is increasing the number of query counts and join counts, etc in many tests. Do we know why?

[github-actions]

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

[sfc-gh-aalam]

This is increasing the number of query counts and join counts, etc in many tests. Do we know why?

I looked into the failed tests and the ones that are have @multithreaded_run at the outermost decorator. This decorator runs the internal tests 5 times and it is interfering with sql_count. I have moved the decorator one level below @sql_count_checker and update the values now. Tests should pass now.

[sfc-gh-aalam]

This is increasing the number of query counts and join counts, etc in many tests. Do we know why?

I looked into the failed tests and the ones that are have @multithreaded_run at the outermost decorator. This decorator runs the internal tests 5 times and it is interfering with sql_count. I have moved the decorator one level below @sql_count_checker and update the values now. Tests should pass now.

The approach above was not as clean. I made the SqlCounter thread-safe now.

[sfc-gh-helmeleegy]

Looks good to me. Thanks!