Skip to content

SNOW-1852428: Remove error print in try/catch#2787

Merged
sfc-gh-yixie merged 9 commits intomainfrom
yixie-SNOW-1852428-remove-error-log-check-pandas
Jan 24, 2025
Merged

SNOW-1852428: Remove error print in try/catch#2787
sfc-gh-yixie merged 9 commits intomainfrom
yixie-SNOW-1852428-remove-error-log-check-pandas

Conversation

@sfc-gh-yixie
Copy link
Collaborator

@sfc-gh-yixie sfc-gh-yixie commented Dec 19, 2024 •
edited
Loading

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1852428

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-yixie sfc-gh-yixie requested review from a team as code owners December 19, 2024 02:18
@sfc-gh-yixie sfc-gh-yixie added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Dec 19, 2024
@sfc-gh-lspiegelberg sfc-gh-lspiegelberg changed the title SNOW-1852428: Remove wrong error log SNOW-1852428: Remove error print in try/catch Jan 22, 2025
@sfc-gh-yixie sfc-gh-yixie force-pushed the yixie-SNOW-1852428-remove-error-log-check-pandas branch from 40e5ee7 to 8318bca Compare January 22, 2025 17:35
sfc-gh-aalam
sfc-gh-aalam approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@sfc-gh-aalam sfc-gh-aalam left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the linter needs to run again

@sfc-gh-yixie sfc-gh-yixie merged commit f801bd0 into main Jan 24, 2025
39 checks passed
@sfc-gh-yixie sfc-gh-yixie deleted the yixie-SNOW-1852428-remove-error-log-check-pandas branch January 24, 2025 19:30
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sfc-gh-aling sfc-gh-aling sfc-gh-aling approved these changes

@sfc-gh-aalam sfc-gh-aalam sfc-gh-aalam approved these changes

@sfc-gh-jrose sfc-gh-jrose sfc-gh-jrose approved these changes

@sfc-gh-smirzaei sfc-gh-smirzaei Awaiting requested review from sfc-gh-smirzaei sfc-gh-smirzaei is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-yuwang sfc-gh-yuwang Awaiting requested review from sfc-gh-yuwang sfc-gh-yuwang is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

+1 more reviewer

@sfc-gh-lspiegelberg sfc-gh-lspiegelberg sfc-gh-lspiegelberg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sfc-gh-yixie @sfc-gh-lspiegelberg @sfc-gh-aling @sfc-gh-aalam @sfc-gh-jrose