SNOW-1805840: Augment telemetry with method_call_count#2804
Merged
sfc-gh-lmukhopadhyay merged 18 commits intomainfrom Jan 14, 2025
Merged
SNOW-1805840: Augment telemetry with method_call_count#2804sfc-gh-lmukhopadhyay merged 18 commits intomainfrom
sfc-gh-lmukhopadhyay merged 18 commits intomainfrom
Conversation
…emetry Signed-off-by: Labanya Mukhopadhyay <labanya.mukhopadhyay@snowflake.com>
sfc-gh-lmukhopadhyay
added
the
NO-PANDAS-CHANGEDOC-UPDATES
Signed-off-by: Labanya Mukhopadhyay <labanya.mukhopadhyay@snowflake.com>
Signed-off-by: Labanya Mukhopadhyay <labanya.mukhopadhyay@snowflake.com>
sfc-gh-lmukhopadhyay
requested review from
sfc-gh-joshi,
sfc-gh-mvashishtha and
sfc-gh-rdurrani
Signed-off-by: Labanya Mukhopadhyay <labanya.mukhopadhyay@snowflake.com>
Signed-off-by: Labanya Mukhopadhyay <labanya.mukhopadhyay@snowflake.com>
src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Labanya Mukhopadhyay <labanya.mukhopadhyay@snowflake.com>
Signed-off-by: Labanya Mukhopadhyay <labanya.mukhopadhyay@snowflake.com>
sfc-gh-mvashishtha
changed the title
sfc-gh-joshi
reviewed
Jan 7, 2025
Contributor
sfc-gh-helmeleegy
left a comment
sfc-gh-helmeleegy
left a comment
There was a problem hiding this comment.
The PR description is talking about introducing interchange_call_count, which I don't think is accurate -- there is no such variable/field.
sfc-gh-helmeleegy
approved these changes
Jan 7, 2025
Contributor
sfc-gh-helmeleegy
left a comment
sfc-gh-helmeleegy
left a comment
There was a problem hiding this comment.
Overall looks good to me. Just left a few nits/questions.
Signed-off-by: Labanya Mukhopadhyay <labanya.mukhopadhyay@snowflake.com>
sfc-gh-joshi
reviewed
Jan 7, 2025
sfc-gh-jjiao
reviewed
Jan 8, 2025
Signed-off-by: Labanya Mukhopadhyay <labanya.mukhopadhyay@snowflake.com>
sfc-gh-jjiao
approved these changes
Jan 8, 2025
Signed-off-by: Labanya Mukhopadhyay <labanya.mukhopadhyay@snowflake.com>
…com:snowflakedb/snowpark-python into lmukhopadhyay-SNOW-1805840-telem-call-count
sfc-gh-lmukhopadhyay
deleted the
lmukhopadhyay-SNOW-1805840-telem-call-count
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1805840
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Adding method_call_count which is the # of times a pandas API method has been called.
See more info in the interchange protocol design doc here: https://docs.google.com/document/d/1EfqQwejVbF5_36hnOP-ap0t3NaCWmDz62iAcR0PtX20/edit?tab=t.0#heading=h.4uu48icmuq7z