SNOW-1852925: Add type inference for Series.apply/map and Dataframe.map#2821
Merged
sfc-gh-nkumar merged 3 commits intomainfrom Jan 8, 2025
Merged
SNOW-1852925: Add type inference for Series.apply/map and Dataframe.map#2821sfc-gh-nkumar merged 3 commits intomainfrom
sfc-gh-nkumar merged 3 commits intomainfrom
Conversation
sfc-gh-nkumar
added
the
NO-PANDAS-CHANGEDOC-UPDATES
sfc-gh-nkumar
force-pushed
the
nkumar-SNOW-1852925-infer
branch
3 times, most recently
from
7e944eb to
c4b9d88
Compare
sfc-gh-jjiao
reviewed
Jan 6, 2025
sfc-gh-jjiao
reviewed
Jan 6, 2025
src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py
Outdated
Show resolved
Hide resolved
sfc-gh-nkumar
force-pushed
the
nkumar-SNOW-1852925-infer
branch
2 times, most recently
from
020fe33 to
4d7bf1e
Compare
sfc-gh-jjiao
approved these changes
Jan 7, 2025
Contributor
sfc-gh-jjiao
left a comment
sfc-gh-jjiao
left a comment
There was a problem hiding this comment.
Thanks, please address comments before merging!
Contributor
There was a problem hiding this comment.
Maybe add a comment here to explain what's going on?
sfc-gh-helmeleegy
approved these changes
Jan 7, 2025
sfc-gh-nkumar
force-pushed
the
nkumar-SNOW-1852925-infer
branch
from
3b180a1 to
ff4ff52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SNOW-1852925 & SNOW-1852928
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-NNNNNNN
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Add type inference for DataFrame.map, Series.apply and Series.map