Skip to content

Fail local-testing check rather than add nag comment#2823

Merged
sfc-gh-jrose merged 1 commit intomainfrom
jrose_snow_update_local_testing_nag
Jan 7, 2025
Merged

Fail local-testing check rather than add nag comment#2823
sfc-gh-jrose merged 1 commit intomainfrom
jrose_snow_update_local_testing_nag

Conversation

@sfc-gh-jrose
Copy link
Contributor

@sfc-gh-jrose sfc-gh-jrose commented Jan 6, 2025

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-NNNNNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
  3. Please describe how your code solves the related issue.

    The nag comments for local testing add a lot of clutter to PRs. This change will instead fail the check with an error message.

@sfc-gh-jrose sfc-gh-jrose force-pushed the jrose_snow_update_local_testing_nag branch from 49d5a33 to 6bf32e4 Compare January 6, 2025 19:41
@sfc-gh-jrose sfc-gh-jrose changed the title Auto add local-testing rather than nag Fail local-testing check rather than add nag comment Jan 6, 2025
@sfc-gh-jrose sfc-gh-jrose requested review from a team and removed request for a team January 6, 2025 19:43
@sfc-gh-jrose sfc-gh-jrose added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Jan 6, 2025
@sfc-gh-jrose sfc-gh-jrose requested a review from a team January 6, 2025 19:52
@sfc-gh-jrose sfc-gh-jrose force-pushed the jrose_snow_update_local_testing_nag branch from b971063 to e4b2815 Compare January 6, 2025 19:53
@sfc-gh-jrose sfc-gh-jrose marked this pull request as ready for review January 6, 2025 19:53
@sfc-gh-jrose sfc-gh-jrose requested review from a team as code owners January 6, 2025 19:54
@sfc-gh-jrose sfc-gh-jrose merged commit 31b5c8f into main Jan 7, 2025
48 checks passed
@sfc-gh-jrose sfc-gh-jrose deleted the jrose_snow_update_local_testing_nag branch January 7, 2025 17:30
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants