Skip to content

SNOW-1869802: Fix local testing pivot returning None#2824

Merged
sfc-gh-jrose merged 4 commits intomainfrom
jrose_snow_1869802_local_testing_pivot_0
Jan 7, 2025
Merged

SNOW-1869802: Fix local testing pivot returning None#2824
sfc-gh-jrose merged 4 commits intomainfrom
jrose_snow_1869802_local_testing_pivot_0

Conversation

@sfc-gh-jrose
Copy link
Contributor

@sfc-gh-jrose sfc-gh-jrose commented Jan 6, 2025

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1869802

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
  3. Please describe how your code solves the related issue.

    This PR fixes an issue when pivoting a dataframe in local testing mode. When all values in a column were falsey local testing would incorrectly assume that None should be returned rather than the falsey value. This change instead checks that all values are null instead of all values are falsey.

@sfc-gh-jrose sfc-gh-jrose requested review from a team and sfc-gh-aling January 6, 2025 20:15
@sfc-gh-jrose sfc-gh-jrose requested review from a team as code owners January 6, 2025 20:15
@github-actions github-actions bot added the local testing Local Testing issues/PRs label Jan 6, 2025
@sfc-gh-jrose sfc-gh-jrose merged commit b64e724 into main Jan 7, 2025
39 checks passed
@sfc-gh-jrose sfc-gh-jrose deleted the jrose_snow_1869802_local_testing_pivot_0 branch January 7, 2025 23:23
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

local testing Local Testing issues/PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants