SNOW-1800374: adding support for options and partition_by to dataframewriter#2841
Merged
sfc-gh-batur merged 4 commits intomainfrom Jan 14, 2025
Merged
SNOW-1800374: adding support for options and partition_by to dataframewriter#2841sfc-gh-batur merged 4 commits intomainfrom
sfc-gh-batur merged 4 commits intomainfrom
Conversation
Contributor
sfc-gh-lspiegelberg
left a comment
There was a problem hiding this comment.
Looks good to me, left some comments. Ping me once it is ready for merge for the final approval!
8dcc4fb to
8c4046c
Compare
tests/ast/data/DataFrame.write.test
Outdated
Contributor
There was a problem hiding this comment.
can we add some repeated calls of .mode(...), .option(...), .options(...)? Just to clarify behavior and preserve for the future.
sfc-gh-lspiegelberg
approved these changes
Jan 10, 2025
Contributor
sfc-gh-lspiegelberg
left a comment
There was a problem hiding this comment.
lgtm, just one ask/nit to clarify behavior for repeated calls.
1ad6d8a to
eafe4dd
Compare
3b46bf4 to
a171b24
Compare
sfc-gh-vbudati
approved these changes
Jan 13, 2025
Contributor
sfc-gh-vbudati
left a comment
There was a problem hiding this comment.
Looks great. Thanks for adding more test cases as well!
sfc-gh-vbudati
approved these changes
Jan 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1800374
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.