Skip to content

SNOW-1875149:allow user input schema when reading JSON file on stage#2859

Merged
sfc-gh-yuwang merged 15 commits intomainfrom
SNOW-1875149
Jan 23, 2025
Merged

SNOW-1875149:allow user input schema when reading JSON file on stage#2859
sfc-gh-yuwang merged 15 commits intomainfrom
SNOW-1875149

Conversation

@sfc-gh-yuwang
Copy link
Collaborator

@sfc-gh-yuwang sfc-gh-yuwang commented Jan 14, 2025 •
edited
Loading

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1875149

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines

  3. Please describe how your code solves the related issue.

    allow user input schema when reading JSON file on stage

@sfc-gh-yuwang sfc-gh-yuwang marked this pull request as ready for review January 14, 2025 17:39
@sfc-gh-yuwang sfc-gh-yuwang requested review from a team as code owners January 14, 2025 17:39
sfc-gh-aling
sfc-gh-aling reviewed Jan 14, 2025
View reviewed changes
sfc-gh-jrose
sfc-gh-jrose reviewed Jan 16, 2025
View reviewed changes
sfc-gh-aalam
sfc-gh-aalam reviewed Jan 17, 2025
View reviewed changes
@github-actions github-actions bot added the local testing Local Testing issues/PRs label Jan 21, 2025
sfc-gh-aalam
sfc-gh-aalam approved these changes Jan 21, 2025
View reviewed changes
@sfc-gh-yuwang sfc-gh-yuwang merged commit 7d4b43c into main Jan 23, 2025
50 of 53 checks passed
@sfc-gh-yuwang sfc-gh-yuwang deleted the SNOW-1875149 branch January 23, 2025 00:29
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sfc-gh-aling sfc-gh-aling sfc-gh-aling approved these changes

@sfc-gh-aalam sfc-gh-aalam sfc-gh-aalam approved these changes

@sfc-gh-jrose sfc-gh-jrose sfc-gh-jrose approved these changes

@sfc-gh-yixie sfc-gh-yixie Awaiting requested review from sfc-gh-yixie sfc-gh-yixie is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

Assignees

No one assigned

Labels

local testing Local Testing issues/PRs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sfc-gh-yuwang @sfc-gh-aling @sfc-gh-aalam @sfc-gh-jrose