SNOW-1882338 Fix AST to_snowpark_pandas test in nop testing mode#2863
Merged
sfc-gh-vbudati merged 1 commit intomainfrom Jan 15, 2025
Merged
Conversation
…ble for to_snowpark_pandas
sfc-gh-jrose
approved these changes
Jan 14, 2025
| source_plan = plan.source_plan | ||
|
|
||
| if hasattr(source_plan, "execution_queries"): | ||
| # If temp read-only table, explicitly create it. |
Contributor
There was a problem hiding this comment.
nit: maybe add a simple unit/integ test for this?
Contributor
Author
There was a problem hiding this comment.
I don't think that's necessary/it would be redundant since the to_snowpark_pandas.test test will fail if there's something wrong with this generation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes SNOW-1882338
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Add logic to the no-op AST testing code to create a temp read-only table for to_snowpark_pandas. This way
to_snowpark_pandasworks with bothnopmode andlocal_testing_mode.