Skip to content

SNOW-1886694 - Track whether snowpark is running in an interactive environment#2879

Merged
sfc-gh-jkew merged 16 commits intomainfrom
jkew/interactive-telemetry-track
Jan 24, 2025
Merged

SNOW-1886694 - Track whether snowpark is running in an interactive environment#2879
sfc-gh-jkew merged 16 commits intomainfrom
jkew/interactive-telemetry-track

Conversation

@sfc-gh-jkew
Copy link
Contributor

@sfc-gh-jkew sfc-gh-jkew commented Jan 17, 2025

SNOW-1886694 - Track whether snowpark is running in an interactive environment
In order to improve interactive performance we need to track it, particularly for snowpandas. We use sys "ps1" and sys.flags.interactive for most runtime environments, but for snowbook we also look for a module availability. Snowbook notebooks can also run non-interactively; but snowbook does not set sys.flags.interactive right now. So this might over-count for snowbook until the flags are set properly.

pre-review checklist:

  • I am adding a new automated test(s) to verify correctness of my new code
    • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
  • I am adding new logging messages
  • I am adding a new telemetry message
  • I am adding new credentials
  • I am adding a new dependency
  • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
  • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines

@sfc-gh-jkew sfc-gh-jkew requested review from a team as code owners January 17, 2025 00:28
@sfc-gh-jkew sfc-gh-jkew marked this pull request as draft January 17, 2025 00:28
@sfc-gh-jkew
Copy link
Contributor Author

Should be in draft for now.

@sfc-gh-jkew sfc-gh-jkew marked this pull request as ready for review January 17, 2025 22:21
@sfc-gh-jkew sfc-gh-jkew requested a review from a team as a code owner January 17, 2025 22:21
Copy link
Contributor

@sfc-gh-mvashishtha sfc-gh-mvashishtha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks!

Copy link
Contributor

@sfc-gh-helmeleegy sfc-gh-helmeleegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one nit.

@sfc-gh-jkew sfc-gh-jkew enabled auto-merge (squash) January 21, 2025 17:37
@sfc-gh-jkew sfc-gh-jkew disabled auto-merge January 24, 2025 18:21
@sfc-gh-jkew sfc-gh-jkew merged commit 872b583 into main Jan 24, 2025
37 checks passed
@sfc-gh-jkew sfc-gh-jkew deleted the jkew/interactive-telemetry-track branch January 24, 2025 18:39
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants