Skip to content

SNOW-1830540 Decoder functionality for union functions and Session.table_function#2883

Merged
sfc-gh-vbudati merged 4 commits intovbudati/SNOW-1794510-merge-decoderfrom
vbudati/SNOW-1830540-decoder-union-table-functions
Jan 18, 2025
Merged

SNOW-1830540 Decoder functionality for union functions and Session.table_function#2883
sfc-gh-vbudati merged 4 commits intovbudati/SNOW-1794510-merge-decoderfrom
vbudati/SNOW-1830540-decoder-union-table-functions

Conversation

@sfc-gh-vbudati
Copy link
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1830540

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
  3. Please describe how your code solves the related issue.

I changed the test for Session.table_function because it logically did not work -- functions that didn't exist were being used in the test. I'll make another PR to the main repo to fix the test as well.

@sfc-gh-vbudati sfc-gh-vbudati requested a review from a team as a code owner January 18, 2025 00:06
@sfc-gh-vbudati sfc-gh-vbudati merged commit 0c726dd into vbudati/SNOW-1794510-merge-decoder Jan 18, 2025
@sfc-gh-vbudati sfc-gh-vbudati deleted the vbudati/SNOW-1830540-decoder-union-table-functions branch January 18, 2025 00:47
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants