Skip to content

SNOW-1893939: Add support for Index.drop_duplicates#2923

Merged
sfc-gh-amaheshwary merged 8 commits intomainfrom
amaheshwary-SNOW-1893939-indexDropDuplicates
Jan 27, 2025
Merged

SNOW-1893939: Add support for Index.drop_duplicates#2923
sfc-gh-amaheshwary merged 8 commits intomainfrom
amaheshwary-SNOW-1893939-indexDropDuplicates

Conversation

@sfc-gh-amaheshwary
Copy link
Contributor

@sfc-gh-amaheshwary sfc-gh-amaheshwary commented Jan 23, 2025

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1893939

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
  3. Please describe how your code solves the related issue.

    Added support for Index.drop_duplicates.

@github-actions
Copy link

github-actions bot commented Jan 23, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@sfc-gh-amaheshwary
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

@sfc-gh-nkrishna sfc-gh-nkrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions around adding more tests, but LGTM overall

Copy link
Contributor

@sfc-gh-nkrishna sfc-gh-nkrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work :)

Copy link
Contributor

@sfc-gh-jjiao sfc-gh-jjiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job for your first PR!

Copy link
Contributor

@sfc-gh-helmeleegy sfc-gh-helmeleegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'd also need to remove references to drop_duplicates in test_unimplemented.py. But looks good otherwise. Congrats on the first PR :)

@sfc-gh-amaheshwary sfc-gh-amaheshwary merged commit 8db5109 into main Jan 27, 2025
38 checks passed
@sfc-gh-amaheshwary sfc-gh-amaheshwary deleted the amaheshwary-SNOW-1893939-indexDropDuplicates branch January 27, 2025 17:59
@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants