SNOW-1893939: Add support for Index.drop_duplicates#2923
Merged
sfc-gh-amaheshwary merged 8 commits intomainfrom Jan 27, 2025
Merged
SNOW-1893939: Add support for Index.drop_duplicates#2923sfc-gh-amaheshwary merged 8 commits intomainfrom
sfc-gh-amaheshwary merged 8 commits intomainfrom
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
sfc-gh-nkrishna
left a comment
There was a problem hiding this comment.
Some minor suggestions around adding more tests, but LGTM overall
sfc-gh-jkew
reviewed
Jan 23, 2025
sfc-gh-nkrishna
approved these changes
Jan 24, 2025
Contributor
sfc-gh-nkrishna
left a comment
There was a problem hiding this comment.
LGTM! Nice work :)
sfc-gh-jjiao
approved these changes
Jan 24, 2025
Contributor
sfc-gh-jjiao
left a comment
There was a problem hiding this comment.
Great job for your first PR!
sfc-gh-jkew
approved these changes
Jan 24, 2025
sfc-gh-helmeleegy
approved these changes
Jan 24, 2025
Contributor
sfc-gh-helmeleegy
left a comment
There was a problem hiding this comment.
You'd also need to remove references to drop_duplicates in test_unimplemented.py. But looks good otherwise. Congrats on the first PR :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1893939
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Added support for Index.drop_duplicates.