Skip to content

NO-SNOW: Spread AST tests across CSPs#2927

Merged
sfc-gh-jrose merged 2 commits intomainfrom
jrose_snow_no_snow_prune_ast_tests
Jan 24, 2025
Merged

NO-SNOW: Spread AST tests across CSPs#2927
sfc-gh-jrose merged 2 commits intomainfrom
jrose_snow_no_snow_prune_ast_tests

Conversation

@sfc-gh-jrose
Copy link
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes NO-SNOW

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
  3. Please describe how your code solves the related issue.

    This PR spreads the ast test runs across CSPs to reduce load on AWS.

@sfc-gh-jrose sfc-gh-jrose added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Jan 24, 2025
python-version: [ "3.9", "3.11", "3.12" ]
cloud-provider: [ aws ]
cloud-provider: [aws, gcp, azure]
exclude:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to change in this PR. But curious if there is a syntax to include the combinations instead of excluding?

@sfc-gh-jrose sfc-gh-jrose merged commit 95824c3 into main Jan 24, 2025
36 of 39 checks passed
@sfc-gh-jrose sfc-gh-jrose deleted the jrose_snow_no_snow_prune_ast_tests branch January 24, 2025 04:41
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants