Skip to content

SNOW-1888076: built-in function support wave1#2928

Merged
sfc-gh-aling merged 12 commits intomainfrom
SNOW-1888076-sma-pyspark-api-coverage
Jan 28, 2025
Merged

SNOW-1888076: built-in function support wave1#2928
sfc-gh-aling merged 12 commits intomainfrom
SNOW-1888076-sma-pyspark-api-coverage

Conversation

@sfc-gh-aling
Copy link
Contributor

@sfc-gh-aling sfc-gh-aling commented Jan 24, 2025

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1888076

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
  3. Please describe how your code solves the related issue.

  • add new functions:
    • base64
    • base64_decode_string
    • base64_encode
    • editdistance
    • hex
    • hex_encode
    • instr
    • log1p
    • log2
    • log10
    • percentile_approx
    • unbase64
  • enhanced:
    • map_cat/map_concat now supports columns more than 2

@sfc-gh-aling sfc-gh-aling marked this pull request as ready for review January 24, 2025 19:28
@sfc-gh-aling sfc-gh-aling requested review from a team as code owners January 24, 2025 19:28
@github-actions github-actions bot added the local testing Local Testing issues/PRs label Jan 28, 2025
Copy link
Contributor

@sfc-gh-lspiegelberg sfc-gh-lspiegelberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@sfc-gh-aling sfc-gh-aling merged commit 7e510c9 into main Jan 28, 2025
37 checks passed
@sfc-gh-aling sfc-gh-aling deleted the SNOW-1888076-sma-pyspark-api-coverage branch January 28, 2025 02:21
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

local testing Local Testing issues/PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants