Skip to content

SNOW-1891120: Use static names for test integrations#2934

Merged
sfc-gh-jrose merged 1 commit intomainfrom
jrose_snow_no_snow_external_access_integration_fix
Jan 28, 2025
Merged

SNOW-1891120: Use static names for test integrations#2934
sfc-gh-jrose merged 1 commit intomainfrom
jrose_snow_no_snow_external_access_integration_fix

Conversation

@sfc-gh-jrose
Copy link
Contributor

@sfc-gh-jrose sfc-gh-jrose commented Jan 24, 2025

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes NO-SNOW

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
  3. Please describe how your code solves the related issue.

    This change reduces change the external access integrations to use static names. These integrations don't appear to have any test session specific requirements so they do not need to be recreated every session. This solves the issue of the integrations getting leaked causing a build-up of unused integrations. It would be better to understand how that leak was occurring.

@sfc-gh-jrose sfc-gh-jrose added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Jan 24, 2025
@sfc-gh-jrose sfc-gh-jrose requested a review from a team as a code owner January 24, 2025 20:49
@sfc-gh-jrose sfc-gh-jrose changed the title NO-SNOW: Reduce maximum number of integrations to 36 SNOW-1891120: Reduce maximum number of integrations to 36 Jan 27, 2025
@sfc-gh-jrose sfc-gh-jrose force-pushed the jrose_snow_no_snow_external_access_integration_fix branch from e4ad78a to 68e303b Compare January 28, 2025 17:17
@sfc-gh-jrose sfc-gh-jrose changed the title SNOW-1891120: Reduce maximum number of integrations to 36 SNOW-1891120: Use static names for test integrations Jan 28, 2025
@sfc-gh-jrose sfc-gh-jrose merged commit 2312206 into main Jan 28, 2025
36 of 39 checks passed
@sfc-gh-jrose sfc-gh-jrose deleted the jrose_snow_no_snow_external_access_integration_fix branch January 28, 2025 18:52
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants