Skip to content

SNOW-1882296: Add support for DataFrame.create_temp_view#2935

Merged
sfc-gh-jdu merged 5 commits intomainfrom
jdu-SNOW-1882296-create-temp-view
Jan 29, 2025
Merged

SNOW-1882296: Add support for DataFrame.create_temp_view#2935
sfc-gh-jdu merged 5 commits intomainfrom
jdu-SNOW-1882296-create-temp-view

Conversation

@sfc-gh-jdu
Copy link
Collaborator

@sfc-gh-jdu sfc-gh-jdu commented Jan 24, 2025 •
edited
Loading

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1882296

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-jdu sfc-gh-jdu requested review from a team as code owners January 24, 2025 22:07
@github-actions github-actions bot added the local testing Local Testing issues/PRs label Jan 24, 2025
sfc-gh-jrose
sfc-gh-jrose approved these changes Jan 28, 2025
View reviewed changes
src/snowflake/snowpark/_internal/analyzer/analyzer_utils.py

def create_or_replace_view_statement(
name: str, child: str, is_temp: bool, comment: Optional[str]
name: str, child: str, is_temp: bool, comment: Optional[str], replace: bool
Copy link
Contributor

@sfc-gh-jrose sfc-gh-jrose Jan 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should replace be True by default in case something else relies on this function?

Copy link
Collaborator Author

@sfc-gh-jdu sfc-gh-jdu Jan 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to keep it without default value so developers calling this function will be aware of whether "replace" really happens or not.

@sfc-gh-jdu sfc-gh-jdu merged commit 2adb5bb into main Jan 29, 2025
33 of 36 checks passed
@sfc-gh-jdu sfc-gh-jdu deleted the jdu-SNOW-1882296-create-temp-view branch January 29, 2025 22:45
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sfc-gh-aalam sfc-gh-aalam sfc-gh-aalam approved these changes

@sfc-gh-jrose sfc-gh-jrose sfc-gh-jrose approved these changes

@sfc-gh-aling sfc-gh-aling Awaiting requested review from sfc-gh-aling sfc-gh-aling is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-yuwang sfc-gh-yuwang Awaiting requested review from sfc-gh-yuwang sfc-gh-yuwang is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

Assignees

No one assigned

Labels

local testing Local Testing issues/PRs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sfc-gh-jdu @sfc-gh-aalam @sfc-gh-jrose