Skip to content

SNOW-1896935 Implement nth_value#2936

Merged
sfc-gh-vbudati merged 6 commits intomainfrom
dryazanov_nth_value
Jan 29, 2025
Merged

SNOW-1896935 Implement nth_value#2936
sfc-gh-vbudati merged 6 commits intomainfrom
dryazanov_nth_value

Conversation

@sfc-gh-dryazanov
Copy link
Contributor

@sfc-gh-dryazanov sfc-gh-dryazanov commented Jan 24, 2025

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1896935

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@github-actions
Copy link

github-actions bot commented Jan 24, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@sfc-gh-aalam
Copy link
Contributor

@sfc-gh-dryazanov will you be able to add an ast related test for this.

@sfc-gh-dryazanov
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@sfc-gh-dryazanov
Copy link
Contributor Author

@sfc-gh-aalam: Sure, let me try right now

@sfc-gh-dryazanov
Copy link
Contributor Author

Could someone merge this? I don't actually have the permissions.

@sfc-gh-vbudati sfc-gh-vbudati merged commit 0acc1ad into main Jan 29, 2025
35 of 37 checks passed
@sfc-gh-vbudati sfc-gh-vbudati deleted the dryazanov_nth_value branch January 29, 2025 18:13
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants