Supporting stored procs in decoder#2947
Merged
sfc-gh-batur merged 8 commits intovbudati/SNOW-1794510-merge-decoderfrom Jan 29, 2025
Merged
Supporting stored procs in decoder#2947sfc-gh-batur merged 8 commits intovbudati/SNOW-1794510-merge-decoderfrom
sfc-gh-batur merged 8 commits intovbudati/SNOW-1794510-merge-decoderfrom
Conversation
tests/ast/test_ast_driver.py
Outdated
| actual_message: proto.Request, | ||
| expected_message: proto.Request, | ||
| exclude_symbols_udfs_and_src: bool = False, | ||
| test_case: TestCase = None, |
Contributor
There was a problem hiding this comment.
why not just take the test case name as the parameter instead of the whole test case?
Contributor
Author
There was a problem hiding this comment.
Mostly in case we wanted more information from the test case, but, that's something we can do when there is a need for it..
sfc-gh-vbudati
approved these changes
Jan 28, 2025
8dc9224
into
vbudati/SNOW-1794510-merge-decoder
6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1830568
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.