Skip to content

SNOW-1887104: Update OBJECT semantics#2971

Merged
sfc-gh-jrose merged 11 commits intomainfrom
jrose_snow_1887104_struct_type_semantic_change
May 9, 2025
Merged

SNOW-1887104: Update OBJECT semantics#2971
sfc-gh-jrose merged 11 commits intomainfrom
jrose_snow_1887104_struct_type_semantic_change

Conversation

@sfc-gh-jrose
Copy link
Copy Markdown
Contributor

@sfc-gh-jrose sfc-gh-jrose commented Feb 4, 2025

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-NNNNNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines
  3. Please describe how your code solves the related issue.

    This change modifies the semantics for OBJECT type when the _use_structured_type_semantics flag is enabled. In this mode both semi-structured and structured OBJECT data will be represented by StructType and MapType only refers to structured MAP data.

Without the flag semi-structured data will continue to refer to MapType(StringType(), StringType()) while structured OBJECT will refer to StructType.

@sfc-gh-jrose sfc-gh-jrose added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Feb 4, 2025
@sfc-gh-jrose sfc-gh-jrose marked this pull request as ready for review February 11, 2025 17:52
@sfc-gh-jrose sfc-gh-jrose requested review from a team as code owners February 11, 2025 17:52
@sfc-gh-yuwang sfc-gh-yuwang deleted the jrose_snow_1887104_struct_type_semantic_change branch February 13, 2025 22:51
@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2025
@sfc-gh-jrose sfc-gh-jrose restored the jrose_snow_1887104_struct_type_semantic_change branch February 13, 2025 23:02
@sfc-gh-jrose sfc-gh-jrose reopened this Feb 13, 2025
@sfc-gh-snowflakedb-snyk-sa
Copy link
Copy Markdown

sfc-gh-snowflakedb-snyk-sa commented Apr 23, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@sfc-gh-jrose sfc-gh-jrose requested a review from a team April 24, 2025 21:20
@sfc-gh-jrose sfc-gh-jrose merged commit 0511a45 into main May 9, 2025
38 of 40 checks passed
@sfc-gh-jrose sfc-gh-jrose deleted the jrose_snow_1887104_struct_type_semantic_change branch May 9, 2025 18:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants