Skip to content

SNOW-1934027: Skip cortex tests on python 3.12. #3039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sfc-gh-mvashishtha merged 1 commit into from
Feb 19, 2025
Merged

SNOW-1934027: Skip cortex tests on python 3.12. #3039

sfc-gh-mvashishtha merged 1 commit into from
Feb 19, 2025

Conversation

@sfc-gh-mvashishtha
Copy link
Contributor

@sfc-gh-mvashishtha sfc-gh-mvashishtha commented Feb 19, 2025 •
edited
Loading

snowflake-ml-python, which provides snowflake.cortex, is not available on python 3.12. Skip the cortex Snowpark pandas tests on python versions >= 3.12.

Fixes SNOW-1934027

@sfc-gh-mvashishtha sfc-gh-mvashishtha added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs labels Feb 19, 2025
@sfc-gh-mvashishtha sfc-gh-mvashishtha marked this pull request as ready for review February 19, 2025 19:13
@sfc-gh-mvashishtha sfc-gh-mvashishtha requested review from a team as code owners February 19, 2025 19:13
sfc-gh-helmeleegy
sfc-gh-helmeleegy approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@sfc-gh-helmeleegy sfc-gh-helmeleegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-mvashishtha sfc-gh-mvashishtha merged commit 3b9424a into main Feb 19, 2025
80 of 99 checks passed
@sfc-gh-mvashishtha sfc-gh-mvashishtha deleted the mvashishtha/SNOW-1934027/skip-cortex-tests-on-python-3-12 branch February 19, 2025 19:16
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sfc-gh-aling sfc-gh-aling sfc-gh-aling approved these changes

@sfc-gh-joshi sfc-gh-joshi sfc-gh-joshi approved these changes

@sfc-gh-helmeleegy sfc-gh-helmeleegy sfc-gh-helmeleegy approved these changes

@sfc-gh-nkumar sfc-gh-nkumar Awaiting requested review from sfc-gh-nkumar sfc-gh-nkumar is a code owner automatically assigned from snowflakedb/snowpark-pandas-api

@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay Awaiting requested review from sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay is a code owner automatically assigned from snowflakedb/snowpark-pandas-api

@sfc-gh-jdu sfc-gh-jdu Awaiting requested review from sfc-gh-jdu sfc-gh-jdu is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-yixie sfc-gh-yixie Awaiting requested review from sfc-gh-yixie sfc-gh-yixie is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-jrose sfc-gh-jrose Awaiting requested review from sfc-gh-jrose sfc-gh-jrose is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

Assignees

No one assigned

Labels

NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs snowpark-pandas

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sfc-gh-mvashishtha @sfc-gh-aling @sfc-gh-joshi @sfc-gh-helmeleegy