-
Notifications
You must be signed in to change notification settings - Fork 141
SNOW-2022698: Rename relaxed_ordering param into enforce_ordering and update default setting #3244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
8adc5f6 to
125f581
Compare
sfc-gh-mvashishtha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is mostly good, but I'm leaving comments that are mostly asking about cases where I think that we can't rely on the ordering from read_snowflake(), but we assume a certain order.
Some of these test cases seem to have the ordering issue even prior to this PR because we were already testing with relaxed_ordering=True, while others now only rely on a non-guaranteed ordering because they are using the new default of enforced_ordering=False. Could you please take on a JIRA ticket to fix 1) in another PR, and also address 2) in this PR? All of this assumes that I've correctly both sets of ordering issues :)
9b8033c to
5ddd563
Compare
61c4e7b to
43ac3ec
Compare
Fair point. Calls using the new default are now followed by an explicit sort step to make sure that we avoid test flakiness. |
|
the changes looks good to me, but I want to ask to run our daily precommit test/pandas precommit test on this PR to see if it has any side effects since this is such a big PR |
@sfc-gh-yuwang Sure. Here are the two jobs. They both look good: |
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-2022698
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Rename relaxed_ordering param into enforce_ordering per @sfc-gh-dolee's recommendation. The default value for the new param will be
enforce_ordering=Falsewhich has the opposite meaning of the previous default valuerelaxed_ordering=False.Tests that were calling
read_snowflakeusing the old default setting will switch to using the new default setting, which results in smaller query counts.