Skip to content

SNOW-2090928: [Local Testing] Fix indexing issue in to_timestamp#3342

Merged
sfc-gh-jrose merged 5 commits intomainfrom
jrose_snow_2090928_local_testing_date_format_filter
May 9, 2025
Merged

SNOW-2090928: [Local Testing] Fix indexing issue in to_timestamp#3342
sfc-gh-jrose merged 5 commits intomainfrom
jrose_snow_2090928_local_testing_date_format_filter

Conversation

@sfc-gh-jrose
Copy link
Copy Markdown
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-2090928

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines
  3. Please describe how your code solves the related issue.

After a filter the pandas index for a dataframe can have gaps. The to_timestamp_* functions where not respecting the index of the input column when creating the output column which led to incorrect results. This changes propagates the index through the transformation in order to fix this issue. This fixes #3333

@sfc-gh-jrose sfc-gh-jrose requested review from a team as code owners May 7, 2025 22:56
@github-actions github-actions bot added the local testing Local Testing issues/PRs label May 7, 2025
@sfc-gh-snowflakedb-snyk-sa
Copy link
Copy Markdown

sfc-gh-snowflakedb-snyk-sa commented May 7, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@sfc-gh-jrose sfc-gh-jrose merged commit f27865a into main May 9, 2025
61 of 67 checks passed
@sfc-gh-jrose sfc-gh-jrose deleted the jrose_snow_2090928_local_testing_date_format_filter branch May 9, 2025 16:11
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

local testing Local Testing issues/PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SNOW-2090928: Unexpected behaviour for date_format in conjunction with filter

4 participants