-
Notifications
You must be signed in to change notification settings - Fork 146
SNOW-1955847: DBAPI Postgres Support #3351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sfc-gh-aling
merged 31 commits into
main
from
SNOW-1955847-feat-add-support-to-postgresql
May 27, 2025
Merged
Changes from 22 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
4211f25
init impl
sfc-gh-aling fd46eb2
fix utc
sfc-gh-aling 8aa988e
impl
sfc-gh-aling 7e70380
Merge branch 'main' into SNOW-1955847-feat-add-support-to-postgresql
sfc-gh-aling 62043f8
Apply suggestions from code review
sfc-gh-aling f76dd51
fix
sfc-gh-aling d10d338
Merge remote-tracking branch 'origin/SNOW-1955847-feat-add-support-to…
sfc-gh-aling 25c475f
add test coverage
sfc-gh-aling 462c558
update tox
sfc-gh-aling 7fece89
Merge branch 'main' into SNOW-1955847-feat-add-support-to-postgresql
sfc-gh-aling bd25ddf
update tox
sfc-gh-aling 599d8af
Merge remote-tracking branch 'origin/SNOW-1955847-feat-add-support-to…
sfc-gh-aling 17f465e
try coverage
sfc-gh-aling e65ed57
Merge remote-tracking branch 'origin/main' into SNOW-1955847-feat-add…
sfc-gh-aling 272dd7f
update
sfc-gh-aling d9671ed
update udtf dep
sfc-gh-aling a7b1b58
add unit test
sfc-gh-aling a6347e0
test dep
sfc-gh-aling b98f9b0
test psycopg2
sfc-gh-aling b94ed56
update changelog
sfc-gh-aling c8f6da6
install psycopg2 bin
sfc-gh-aling 50628cf
update cred
sfc-gh-aling 656faf7
update tox
sfc-gh-aling 642dc32
temp skip test workflow
sfc-gh-aling e0477db
revert workflow change
sfc-gh-aling cceb8c3
Merge remote-tracking branch 'origin/main' into SNOW-1955847-feat-add…
sfc-gh-aling e3980eb
Update tox.ini
sfc-gh-aling 98ef4d3
update test code
sfc-gh-aling f6e470b
Merge remote-tracking branch 'origin/SNOW-1955847-feat-add-support-to…
sfc-gh-aling 3b6d885
Merge branch 'main' into SNOW-1955847-feat-add-support-to-postgresql
sfc-gh-aling c46c29e
Merge branch 'main' into SNOW-1955847-feat-add-support-to-postgresql
sfc-gh-aling File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 changes: 40 additions & 0 deletions
40
src/snowflake/snowpark/_internal/data_source/dbms_dialects/postgresql_dialect.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| # | ||
| # Copyright (c) 2012-2025 Snowflake Computing Inc. All rights reserved. | ||
| # | ||
| from typing import List | ||
|
|
||
| from snowflake.snowpark._internal.data_source.dbms_dialects import BaseDialect | ||
| from snowflake.snowpark._internal.data_source.drivers.psycopg2_driver import ( | ||
| Psycopg2TypeCode, | ||
| ) | ||
| from snowflake.snowpark.types import StructType | ||
|
|
||
|
|
||
| class PostgresDialect(BaseDialect): | ||
| @staticmethod | ||
| def generate_select_query( | ||
| table_or_query: str, schema: StructType, raw_schema: List[tuple] | ||
| ) -> str: | ||
| cols = [] | ||
| for _field, raw_field in zip(schema.fields, raw_schema): | ||
| # databricks-sql-connector returns list of tuples for MapType | ||
| # here we push down to-dict conversion to Databricks | ||
sfc-gh-aling marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| type_code = raw_field[1] | ||
| if type_code in ( | ||
| Psycopg2TypeCode.JSONB.value, | ||
| Psycopg2TypeCode.JSON.value, | ||
| ): | ||
| cols.append(f"""TO_JSON("{raw_field[0]}")::TEXT AS {raw_field[0]}""") | ||
| elif type_code == Psycopg2TypeCode.CASHOID.value: | ||
| cols.append( | ||
| f"""CASE WHEN "{raw_field[0]}" IS NULL THEN NULL ELSE FORMAT('"%s"', "{raw_field[0]}"::TEXT) END AS {raw_field[0]}""" | ||
| ) | ||
| elif type_code == Psycopg2TypeCode.BYTEAOID.value: | ||
| cols.append(f"""ENCODE("{raw_field[0]}", 'HEX') AS {raw_field[0]}""") | ||
| elif type_code == Psycopg2TypeCode.TIMETZOID.value: | ||
| cols.append(f""""{raw_field[0]}"::TIME AS {raw_field[0]}""") | ||
| elif type_code == Psycopg2TypeCode.INTERVALOID.value: | ||
| cols.append(f""""{raw_field[0]}"::TEXT AS {raw_field[0]}""") | ||
| else: | ||
| cols.append(f'"{raw_field[0]}"') | ||
| return f"""SELECT {", ".join(cols)} FROM {table_or_query}""" | ||
sfc-gh-aling marked this conversation as resolved.
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.