Skip to content

SNOW-2090084: Add support for reading files from S3 buckets using pd.read_csv#3357

Merged
sfc-gh-helmeleegy merged 3 commits intomainfrom
helmeleegy-SNOW-2090084
May 13, 2025
Merged

SNOW-2090084: Add support for reading files from S3 buckets using pd.read_csv#3357
sfc-gh-helmeleegy merged 3 commits intomainfrom
helmeleegy-SNOW-2090084

Conversation

@sfc-gh-helmeleegy
Copy link
Copy Markdown
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-2090084

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines
  3. Please describe how your code solves the related issue.

    Add support for reading files from S3 buckets using pd.read_csv.

@sfc-gh-snowflakedb-snyk-sa
Copy link
Copy Markdown

sfc-gh-snowflakedb-snyk-sa commented May 13, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

Copy link
Copy Markdown
Contributor

@sfc-gh-nkrishna sfc-gh-nkrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice to see this get in!

Copy link
Copy Markdown
Contributor

@sfc-gh-joshi sfc-gh-joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember a Slack thread from last year discussing read_csv from URLs: https://snowflake.slack.com/archives/C04HF38JFAQ/p1704996741990029

Are the security concerns here no longer relevant since we're directly uploading to a stage, rather than running any code in a sproc/UDF?

@sfc-gh-helmeleegy
Copy link
Copy Markdown
Contributor Author

I remember a Slack thread from last year discussing read_csv from URLs: https://snowflake.slack.com/archives/C04HF38JFAQ/p1704996741990029

Are the security concerns here no longer relevant since we're directly uploading to a stage, rather than running any code in a sproc/UDF?

Yes, using an external stage should not be posing those security concerns. More context here: https://snowflakecomputing.atlassian.net/browse/SNOW-2027409?focusedCommentId=6889625

@sfc-gh-helmeleegy sfc-gh-helmeleegy added the NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs label May 13, 2025
Copy link
Copy Markdown
Contributor

@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@sfc-gh-helmeleegy sfc-gh-helmeleegy merged commit 1973988 into main May 13, 2025
41 of 45 checks passed
@sfc-gh-helmeleegy sfc-gh-helmeleegy deleted the helmeleegy-SNOW-2090084 branch May 13, 2025 23:53
@github-actions github-actions bot locked and limited conversation to collaborators May 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs snowpark-pandas

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants