SNOW-2090084: Add support for reading files from S3 buckets using pd.read_csv#3357
SNOW-2090084: Add support for reading files from S3 buckets using pd.read_csv#3357sfc-gh-helmeleegy merged 3 commits intomainfrom
Conversation
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
sfc-gh-nkrishna
left a comment
There was a problem hiding this comment.
LGTM, nice to see this get in!
sfc-gh-joshi
left a comment
There was a problem hiding this comment.
I remember a Slack thread from last year discussing read_csv from URLs: https://snowflake.slack.com/archives/C04HF38JFAQ/p1704996741990029
Are the security concerns here no longer relevant since we're directly uploading to a stage, rather than running any code in a sproc/UDF?
Yes, using an external stage should not be posing those security concerns. More context here: https://snowflakecomputing.atlassian.net/browse/SNOW-2027409?focusedCommentId=6889625 |
sfc-gh-lmukhopadhyay
left a comment
There was a problem hiding this comment.
Looks great, thanks!
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-2090084
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Add support for reading files from S3 buckets using pd.read_csv.