Skip to content

SNOW-2103487, SNOW-2103488: Make index=False by default for DataFrame/Series.to_view/to_dynamic_table #3360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sfc-gh-helmeleegy merged 2 commits into from
May 15, 2025
Merged

SNOW-2103487, SNOW-2103488: Make index=False by default for DataFrame/Series.to_view/to_dynamic_table #3360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65d5bbc
SNOW-2103487, SNOW-213488: Make index=False by default for DataFrame/…
sfc-gh-helmeleegy May 14, 2025
18ba294
fix errors
sfc-gh-helmeleegy May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
#### Improvements

- Make `iceberg_config` a required parameter for `DataFrame.to_iceberg` and `Series.to_iceberg`.
- Set the default value of the `index` parameter to `False` for `DataFrame.to_view`, `Series.to_view`, `DataFrame.to_dynamic_table`, and `Series.to_dynamic_table`.

## 1.31.1 (2025-05-05)

Expand Down
16 changes: 8 additions & 8 deletions src/snowflake/snowpark/modin/plugin/extensions/dataframe_extensions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ def create_or_replace_view(
name: Union[str, Iterable[str]],
*,
comment: Optional[str] = None,
index: bool = True,
index: bool = False,
index_label: Optional[IndexLabel] = None,
) -> List[Row]:
"""
Expand All @@ -280,7 +280,7 @@ def create_or_replace_view(
that specifies the database name, schema name, and view name.
comment: Adds a comment for the created view. See
`COMMENT <https://docs.snowflake.com/en/sql-reference/sql/comment>`_.
index: default True
index: default False
If true, save DataFrame index columns in view columns.
index_label:
Column label for index column(s). If None is given (default) and index is True,
Expand Down Expand Up @@ -310,7 +310,7 @@ def create_or_replace_dynamic_table(
data_retention_time: Optional[int] = None,
max_data_extension_time: Optional[int] = None,
iceberg_config: Optional[dict] = None,
index: bool = True,
index: bool = False,
index_label: Optional[IndexLabel] = None,
) -> List[Row]:
"""
Expand Down Expand Up @@ -354,7 +354,7 @@ def create_or_replace_dynamic_table(
- base_location: the base directory that snowflake can write iceberg metadata and files to.
- catalog_sync: optionally sets the catalog integration configured for Polaris Catalog.
- storage_serialization_policy: specifies the storage serialization policy for the table.
index: default True
index: default False
If true, save DataFrame index columns as table columns.
index_label:
Column label for index column(s). If None is given (default) and index is True,
Expand Down Expand Up @@ -389,7 +389,7 @@ def to_view(
name: Union[str, Iterable[str]],
*,
comment: Optional[str] = None,
index: bool = True,
index: bool = False,
index_label: Optional[IndexLabel] = None,
) -> List[Row]:
"""
Expand All @@ -406,7 +406,7 @@ def to_view(
that specifies the database name, schema name, and view name.
comment: Adds a comment for the created view. See
`COMMENT <https://docs.snowflake.com/en/sql-reference/sql/comment>`_.
index: default True
index: default False
If true, save DataFrame index columns in view columns.
index_label:
Column label for index column(s). If None is given (default) and index is True,
Expand Down Expand Up @@ -436,7 +436,7 @@ def to_dynamic_table(
data_retention_time: Optional[int] = None,
max_data_extension_time: Optional[int] = None,
iceberg_config: Optional[dict] = None,
index: bool = True,
index: bool = False,
index_label: Optional[IndexLabel] = None,
) -> List[Row]:
"""
Expand Down Expand Up @@ -480,7 +480,7 @@ def to_dynamic_table(
- base_location: the base directory that snowflake can write iceberg metadata and files to.
- catalog_sync: optionally sets the catalog integration configured for Polaris Catalog.
- storage_serialization_policy: specifies the storage serialization policy for the table.
index: default True
index: default False
If true, save DataFrame index columns as table columns.
index_label:
Column label for index column(s). If None is given (default) and index is True,
Expand Down
16 changes: 8 additions & 8 deletions src/snowflake/snowpark/modin/plugin/extensions/series_extensions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ def create_or_replace_view(
name: Union[str, Iterable[str]],
*,
comment: Optional[str] = None,
index: bool = True,
index: bool = False,
index_label: Optional[IndexLabel] = None,
) -> List[Row]:
"""
Expand All @@ -270,7 +270,7 @@ def create_or_replace_view(
that specifies the database name, schema name, and view name.
comment: Adds a comment for the created view. See
`COMMENT <https://docs.snowflake.com/en/sql-reference/sql/comment>`_.
index: default True
index: default False
If true, save DataFrame index columns in view columns.
index_label:
Column label for index column(s). If None is given (default) and index is True,
Expand Down Expand Up @@ -300,7 +300,7 @@ def create_or_replace_dynamic_table(
data_retention_time: Optional[int] = None,
max_data_extension_time: Optional[int] = None,
iceberg_config: Optional[dict] = None,
index: bool = True,
index: bool = False,
index_label: Optional[IndexLabel] = None,
) -> List[Row]:
"""
Expand Down Expand Up @@ -344,7 +344,7 @@ def create_or_replace_dynamic_table(
- base_location: the base directory that snowflake can write iceberg metadata and files to.
- catalog_sync: optionally sets the catalog integration configured for Polaris Catalog.
- storage_serialization_policy: specifies the storage serialization policy for the table.
index: default True
index: default False
If true, save DataFrame index columns as table columns.
index_label:
Column label for index column(s). If None is given (default) and index is True,
Expand Down Expand Up @@ -379,7 +379,7 @@ def to_view(
name: Union[str, Iterable[str]],
*,
comment: Optional[str] = None,
index: bool = True,
index: bool = False,
index_label: Optional[IndexLabel] = None,
) -> List[Row]:
"""
Expand All @@ -396,7 +396,7 @@ def to_view(
that specifies the database name, schema name, and view name.
comment: Adds a comment for the created view. See
`COMMENT <https://docs.snowflake.com/en/sql-reference/sql/comment>`_.
index: default True
index: default False
If true, save DataFrame index columns in view columns.
index_label:
Column label for index column(s). If None is given (default) and index is True,
Expand Down Expand Up @@ -426,7 +426,7 @@ def to_dynamic_table(
data_retention_time: Optional[int] = None,
max_data_extension_time: Optional[int] = None,
iceberg_config: Optional[dict] = None,
index: bool = True,
index: bool = False,
index_label: Optional[IndexLabel] = None,
) -> List[Row]:
"""
Expand Down Expand Up @@ -470,7 +470,7 @@ def to_dynamic_table(
- base_location: the base directory that snowflake can write iceberg metadata and files to.
- catalog_sync: optionally sets the catalog integration configured for Polaris Catalog.
- storage_serialization_policy: specifies the storage serialization policy for the table.
index: default True
index: default False
If true, save DataFrame index columns as table columns.
index_label:
Column label for index column(s). If None is given (default) and index is True,
Expand Down
Loading