SNOW-2104775: show relevant info how to solve mismatching Modin versi…#3364
SNOW-2104775: show relevant info how to solve mismatching Modin versi…#3364sfc-gh-jjiao wants to merge 7 commits intomainfrom
Conversation
…on in interactive environment
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
sfc-gh-mvashishtha
left a comment
There was a problem hiding this comment.
@sfc-gh-jjiao thanks for starting the fix! There is some more work needed here, so please feel free transfer the PR to someone else in Snowpark pandas if you prefer.
We should also add tests in tests/unit/modin/test_python_version.py that mock different values of sys to simulate combinations of {interactive, not-interactive} and {Snowflake notebooks, not Snowflake notebooks} and check that we output the correct message.
sfc-gh-mvashishtha
left a comment
There was a problem hiding this comment.
I have two wording nits, but we still need tests as well. Please see my earlier comment: #3364 (review)
Co-authored-by: Mahesh Vashishtha <mahesh.vashishtha@snowflake.com>
Co-authored-by: Mahesh Vashishtha <mahesh.vashishtha@snowflake.com>
|
Closing since this has already been covered by another merged PR: #3413 |
…on in interactive environment
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-2104775
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
This is just making the error message more relevant/helpful when there is a mismatching of Modin version in an interactive environment.