Skip to content

SNOW-2104775: show relevant info how to solve mismatching Modin versi…#3364

Closed
sfc-gh-jjiao wants to merge 7 commits intomainfrom
jjiao/different-err-msg-for-notebook
Closed

SNOW-2104775: show relevant info how to solve mismatching Modin versi…#3364
sfc-gh-jjiao wants to merge 7 commits intomainfrom
jjiao/different-err-msg-for-notebook

Conversation

@sfc-gh-jjiao
Copy link
Copy Markdown
Contributor

…on in interactive environment

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-2104775

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines
  3. Please describe how your code solves the related issue.

This is just making the error message more relevant/helpful when there is a mismatching of Modin version in an interactive environment.

@sfc-gh-snowflakedb-snyk-sa
Copy link
Copy Markdown

sfc-gh-snowflakedb-snyk-sa commented May 14, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@sfc-gh-jjiao sfc-gh-jjiao added the NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs label May 14, 2025
@sfc-gh-jjiao sfc-gh-jjiao marked this pull request as ready for review May 14, 2025 18:42
@sfc-gh-jjiao sfc-gh-jjiao requested a review from a team as a code owner May 14, 2025 18:42
Copy link
Copy Markdown
Contributor

@sfc-gh-mvashishtha sfc-gh-mvashishtha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sfc-gh-jjiao thanks for starting the fix! There is some more work needed here, so please feel free transfer the PR to someone else in Snowpark pandas if you prefer.

We should also add tests in tests/unit/modin/test_python_version.py that mock different values of sys to simulate combinations of {interactive, not-interactive} and {Snowflake notebooks, not Snowflake notebooks} and check that we output the correct message.

Copy link
Copy Markdown
Contributor

@sfc-gh-mvashishtha sfc-gh-mvashishtha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have two wording nits, but we still need tests as well. Please see my earlier comment: #3364 (review)

sfc-gh-jjiao and others added 2 commits May 14, 2025 15:02
Co-authored-by: Mahesh Vashishtha <mahesh.vashishtha@snowflake.com>
Co-authored-by: Mahesh Vashishtha <mahesh.vashishtha@snowflake.com>
@sfc-gh-helmeleegy
Copy link
Copy Markdown
Contributor

Closing since this has already been covered by another merged PR: #3413

@github-actions github-actions bot locked and limited conversation to collaborators Jun 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs snowpark-pandas

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants