-
Notifications
You must be signed in to change notification settings - Fork 146
SNOW-2099580: fix Snowpark does not return a dataframe if default argument for called sp not given in session.call #3365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2900547
add is_return_table
sfc-gh-yuwang 086b761
address commnets
sfc-gh-yuwang 8d88be1
Merge branch 'main' into SNOW-2099580
sfc-gh-yuwang c04a797
move changelog
sfc-gh-yuwang 19e0495
fix test
sfc-gh-yuwang 2b27787
Merge branch 'main' into SNOW-2099580
sfc-gh-yuwang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4114,6 +4114,7 @@ def call( | |
| *args: Any, | ||
| statement_params: Optional[Dict[str, Any]] = None, | ||
| log_on_exception: bool = False, | ||
| return_dataframe: Optional[bool] = None, | ||
sfc-gh-aling marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| _emit_ast: bool = True, | ||
| ) -> Any: | ||
| """Calls a stored procedure by name. | ||
|
|
@@ -4124,6 +4125,8 @@ def call( | |
| statement_params: Dictionary of statement level parameters to be set while executing this action. | ||
| log_on_exception: Log warnings if they arise when trying to determine if the stored procedure | ||
| as a table return type. | ||
| return_dataframe: When set to True, the return value of this function is a DataFrame object. | ||
| This is useful when the given stored procedure's return type is a table. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. let's also add comment about default None behavior |
||
|
|
||
| Example:: | ||
|
|
||
|
|
@@ -4163,6 +4166,7 @@ def call( | |
| *args, | ||
| statement_params=statement_params, | ||
| log_on_exception=log_on_exception, | ||
| is_return_table=return_dataframe, | ||
| _emit_ast=_emit_ast, | ||
| ) | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the call functions has parameter named
return_dataframewhile here it's calledis_return_tablewhich name we want to use?