Skip to content

Conversation

@sfc-gh-aling
Copy link
Contributor

@sfc-gh-aling sfc-gh-aling commented Jun 2, 2025

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-NNNNNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines
  3. Please describe how your code solves the related issue.

test running:

diamond join test are passing
https://github.com/snowflakedb/snowpark-python/actions/runs/15423809004

@sfc-gh-aling sfc-gh-aling changed the title fix failing diamond join test SNOW-2060042: fix failing diamond join test Jun 3, 2025
@sfc-gh-aling sfc-gh-aling changed the title SNOW-2060042: fix failing diamond join test SNOW-2060042: fix failing diamond join daily precommit test Jun 3, 2025
@sfc-gh-aling sfc-gh-aling marked this pull request as ready for review June 3, 2025 20:05
@sfc-gh-aling sfc-gh-aling requested a review from a team as a code owner June 3, 2025 20:05
union_count=0,
join_count=0,
cte_join_count=0,
describe_count_for_optimized=6 if session._join_alias_fix else None,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's because of the implementation change of time_series_agg

previously impl uses "join" which produce aliases that needs to be resolved by check attrs by sending desc query in join alias fix but now it doesn't use join.

in the meanwhile, the alias join fix test job is not run per PR, the daily test failure was omitted and lately discovered

@sfc-gh-aling sfc-gh-aling merged commit b758017 into main Jun 3, 2025
90 of 138 checks passed
@sfc-gh-aling sfc-gh-aling deleted the SNOW-2060042-diamond-join-tests-failing-with-cte-optimization branch June 3, 2025 21:25
@github-actions github-actions bot locked and limited conversation to collaborators Jun 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants