SNOW-2060042: fix failing diamond join daily precommit test#3420
Merged
sfc-gh-aling merged 3 commits intomainfrom Jun 3, 2025
Merged
Conversation
sfc-gh-jrose
reviewed
Jun 3, 2025
| union_count=0, | ||
| join_count=0, | ||
| cte_join_count=0, | ||
| describe_count_for_optimized=6 if session._join_alias_fix else None, |
Contributor
Author
There was a problem hiding this comment.
I believe it's because of the implementation change of time_series_agg
previously impl uses "join" which produce aliases that needs to be resolved by check attrs by sending desc query in join alias fix but now it doesn't use join.
in the meanwhile, the alias join fix test job is not run per PR, the daily test failure was omitted and lately discovered
sfc-gh-jdu
approved these changes
Jun 3, 2025
sfc-gh-jrose
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-NNNNNNN
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
test running:
diamond join test are passing
https://github.com/snowflakedb/snowpark-python/actions/runs/15423809004