SNOW-1757443: Implement GroupBy rolling #3686
Conversation
Signed-off-by: Labanya Mukhopadhyay <labanya.mukhopadhyay@snowflake.com>
Signed-off-by: Labanya Mukhopadhyay <labanya.mukhopadhyay@snowflake.com>
Signed-off-by: Labanya Mukhopadhyay <labanya.mukhopadhyay@snowflake.com>
Signed-off-by: Labanya Mukhopadhyay <labanya.mukhopadhyay@snowflake.com>
Signed-off-by: Labanya Mukhopadhyay <labanya.mukhopadhyay@snowflake.com>
src/snowflake/snowpark/modin/plugin/extensions/rolling_groupby_overrides.py
Outdated
Show resolved
Hide resolved
src/snowflake/snowpark/modin/plugin/extensions/rolling_groupby_overrides.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Labanya Mukhopadhyay <labanya.mukhopadhyay@snowflake.com>
Signed-off-by: Labanya Mukhopadhyay <labanya.mukhopadhyay@snowflake.com>
Signed-off-by: Labanya Mukhopadhyay <labanya.mukhopadhyay@snowflake.com>
src/snowflake/snowpark/modin/plugin/extensions/rolling_groupby_overrides.py
Show resolved
Hide resolved
src/snowflake/snowpark/modin/plugin/extensions/rolling_groupby_overrides.py
Show resolved
Hide resolved
src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py
Show resolved
Hide resolved
|
Hi @sfc-gh-lmukhopadhyay, did you get a chance to take a look at the comments I left a while back? |
Actually, nvm. I just noticed that you are in the process of making code changes to address them already. |
Signed-off-by: Labanya Mukhopadhyay <labanya.mukhopadhyay@snowflake.com>
Signed-off-by: Labanya Mukhopadhyay <labanya.mukhopadhyay@snowflake.com>
sfc-gh-mvashishtha
left a comment
There was a problem hiding this comment.
just the query compiler left to review
src/snowflake/snowpark/modin/plugin/extensions/dataframe_groupby_overrides.py
Outdated
Show resolved
Hide resolved
src/snowflake/snowpark/modin/plugin/extensions/rolling_groupby_overrides.py
Outdated
Show resolved
Hide resolved
src/snowflake/snowpark/modin/plugin/extensions/rolling_groupby_overrides.py
Outdated
Show resolved
Hide resolved
src/snowflake/snowpark/modin/plugin/extensions/rolling_groupby_overrides.py
Outdated
Show resolved
Hide resolved
src/snowflake/snowpark/modin/plugin/extensions/rolling_groupby_overrides.py
Outdated
Show resolved
Hide resolved
sfc-gh-mvashishtha
left a comment
There was a problem hiding this comment.
I got through line 5585 of the query compiler.
src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py
Outdated
Show resolved
Hide resolved
src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py
Outdated
Show resolved
Hide resolved
src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py
Outdated
Show resolved
Hide resolved
src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py
Show resolved
Hide resolved
src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py
Outdated
Show resolved
Hide resolved
src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py
Outdated
Show resolved
Hide resolved
sfc-gh-helmeleegy
left a comment
There was a problem hiding this comment.
Thanks for addressing my comments. LGTM after addressing Mahesh's remaining comments.
sfc-gh-mvashishtha
left a comment
There was a problem hiding this comment.
I took one pass through all the files
Signed-off-by: Labanya Mukhopadhyay <labanya.mukhopadhyay@snowflake.com>
Signed-off-by: Labanya Mukhopadhyay <labanya.mukhopadhyay@snowflake.com>
Signed-off-by: Labanya Mukhopadhyay <labanya.mukhopadhyay@snowflake.com>
Signed-off-by: Labanya Mukhopadhyay <labanya.mukhopadhyay@snowflake.com>
Signed-off-by: Labanya Mukhopadhyay <labanya.mukhopadhyay@snowflake.com>
sfc-gh-mvashishtha
left a comment
There was a problem hiding this comment.
Thanks for addressing my comments. I have a few more.
src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py
Outdated
Show resolved
Hide resolved
src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py
Outdated
Show resolved
Hide resolved
src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Labanya Mukhopadhyay <labanya.mukhopadhyay@snowflake.com>
Signed-off-by: Labanya Mukhopadhyay <labanya.mukhopadhyay@snowflake.com>
Signed-off-by: Labanya Mukhopadhyay <labanya.mukhopadhyay@snowflake.com>
src/snowflake/snowpark/modin/plugin/extensions/rolling_groupby_overrides.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Labanya Mukhopadhyay <labanya.mukhopadhyay@snowflake.com>
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1757443
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.