Skip to content

NO SNOW: fix daily precommit to include localtesting#3790

Merged
sfc-gh-yuwang merged 1 commit intomainfrom
yuwang-fix-precommit
Sep 17, 2025
Merged

NO SNOW: fix daily precommit to include localtesting#3790
sfc-gh-yuwang merged 1 commit intomainfrom
yuwang-fix-precommit

Conversation

@sfc-gh-yuwang
Copy link
Collaborator

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-NNNNNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-yuwang
Copy link
Collaborator Author

https://github.com/snowflakedb/snowpark-python/actions/runs/17807625716/job/50623515484
the action can verify that local testing are now run in daily precommit, but there are some error in those tests, fix shall be in another PR

@sfc-gh-yuwang sfc-gh-yuwang added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Sep 17, 2025
@sfc-gh-yuwang sfc-gh-yuwang merged commit 8c7d661 into main Sep 17, 2025
115 of 123 checks passed
@sfc-gh-yuwang sfc-gh-yuwang deleted the yuwang-fix-precommit branch September 17, 2025 22:40
@github-actions github-actions bot locked and limited conversation to collaborators Sep 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants