SNOW-2370108: snowpark fails when group by agg called twice on the same df#3819
Merged
sfc-gh-aling merged 7 commits intomainfrom Sep 30, 2025
Conversation
…-fails-when-group-by-agg-called-twice-on-the-same-df
sfc-gh-aling
commented
Sep 29, 2025
Comment on lines
-733
to
-744
| - if: ${{ matrix.python-version == '3.12' }} | ||
| name: Run tests (excluding doctests and udf tests) | ||
| run: python -m tox -e "py${PYTHON_VERSION/\./}-notudfdoctest-ci" | ||
| env: | ||
| PYTHON_VERSION: ${{ matrix.python-version }} | ||
| cloud_provider: ${{ matrix.cloud-provider }} | ||
| PYTEST_ADDOPTS: --color=yes --tb=short --join_alias_fix | ||
| TOX_PARALLEL_NO_SPINNER: 1 | ||
| SNOWFLAKE_IS_PYTHON_RUNTIME_TEST: 1 | ||
| SNOWPARK_PYTHON_API_TEST_BUCKET_PATH: ${{ secrets.SNOWPARK_PYTHON_API_TEST_BUCKET_PATH }} | ||
| SNOWPARK_PYTHON_API_S3_STORAGE_INTEGRATION: ${{ vars.SNOWPARK_PYTHON_API_S3_STORAGE_INTEGRATION }} | ||
| shell: bash |
Contributor
Author
There was a problem hiding this comment.
clean up work, this part is already covered in Run tests (excluding doctests)
sfc-gh-jrose
approved these changes
Sep 29, 2025
sfc-gh-jdu
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
The _join_alias_fix previously mutates the original expr_to_alias map of a plan, the fix is to create a new object and update the new object to avoid mutating existing ones.
also fix test failure in daily precommit as well as some cleanup work
daily precommit test passing: https://github.com/snowflakedb/snowpark-python/actions/runs/18113970923/job/51546036912
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.