SNOW-2397758: Add parameter for aliasing interval function names#3859
Merged
sfc-gh-aling merged 2 commits intomainfrom Oct 20, 2025
Merged
SNOW-2397758: Add parameter for aliasing interval function names#3859sfc-gh-aling merged 2 commits intomainfrom
sfc-gh-aling merged 2 commits intomainfrom
Conversation
57c3e23 to
e1cd070
Compare
d32c53e to
c0abee7
Compare
sfc-gh-aling
reviewed
Oct 7, 2025
sfc-gh-aling
reviewed
Oct 7, 2025
Base automatically changed from
fhe-SNOW-2392212-fix-floating-point-errors-in-interval-day-time-from-parts
to
main
October 9, 2025 17:09
sfc-gh-aling
reviewed
Oct 9, 2025
sfc-gh-aling
approved these changes
Oct 10, 2025
65ac4ea to
22d40a3
Compare
Comment on lines
+11096
to
+11097
| res = cast(interval_string, "INTERVAL YEAR TO MONTH") | ||
| if _alias_column_name: |
Contributor
There was a problem hiding this comment.
I think this shows the need for a server side implementation for this function.
sfc-gh-aalam
approved these changes
Oct 14, 2025
22d40a3 to
76feec6
Compare
76feec6 to
2ef8b10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-NNNNNNN
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Currently we alias the column name for the interval_day_time_from_parts and interval_year_month_from_parts functions. However, it runs into a bug when we try to use it in a when statement. So, I'm introducing a parameter to allow us to use / not use the alias at will.