Skip to content

SNOW-2432798: Add support for agg/min/max/count/sum/mean/median/std/var and set_columns in faster pandas#3902

Merged
sfc-gh-helmeleegy merged 7 commits intomainfrom
helmeleegy-SNOW-2432798
Oct 17, 2025
Merged

SNOW-2432798: Add support for agg/min/max/count/sum/mean/median/std/var and set_columns in faster pandas#3902
sfc-gh-helmeleegy merged 7 commits intomainfrom
helmeleegy-SNOW-2432798

Conversation

@sfc-gh-helmeleegy
Copy link
Contributor

@sfc-gh-helmeleegy sfc-gh-helmeleegy commented Oct 15, 2025 •
edited
Loading

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-2432798

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines

  3. Please describe how your code solves the related issue.

    Add support for agg/min/max/count/sum/mean/median/std/var and set_columns in faster pandas.

@sfc-gh-helmeleegy sfc-gh-helmeleegy requested a review from a team as a code owner October 15, 2025 22:03
@sfc-gh-helmeleegy sfc-gh-helmeleegy added the NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs label Oct 15, 2025
@sfc-gh-helmeleegy sfc-gh-helmeleegy changed the title SNOW-243798: Add support for agg/min/max/count/sum/mean/median/std/var in faster pandas SNOW-243798: Add support for agg/min/max/count/sum/mean/median/std/var and set_columns in faster pandas Oct 15, 2025
sfc-gh-helmeleegy
sfc-gh-helmeleegy commented Oct 15, 2025
View reviewed changes
src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py
@@ -2314,6 +2314,20 @@ def cache_result(self) -> "SnowflakeQueryCompiler":

@snowpark_pandas_type_immutable_check
def set_columns(self, new_pandas_labels: Axes) -> "SnowflakeQueryCompiler":
Copy link
Contributor Author

@sfc-gh-helmeleegy sfc-gh-helmeleegy Oct 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was necessary for the aggregate functions to work in faster pandas.

graphite-app[bot]
graphite-app bot reviewed Oct 16, 2025
View reviewed changes
@sfc-gh-helmeleegy sfc-gh-helmeleegy merged commit 2437edc into main Oct 17, 2025
27 of 28 checks passed
@sfc-gh-helmeleegy sfc-gh-helmeleegy deleted the helmeleegy-SNOW-2432798 branch October 17, 2025 17:52
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2025
@sfc-gh-helmeleegy sfc-gh-helmeleegy changed the title SNOW-243798: Add support for agg/min/max/count/sum/mean/median/std/var and set_columns in faster pandas SNOW-2432798: Add support for agg/min/max/count/sum/mean/median/std/var and set_columns in faster pandas Oct 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@sfc-gh-jkew sfc-gh-jkew sfc-gh-jkew approved these changes

@sfc-gh-mvashishtha sfc-gh-mvashishtha Awaiting requested review from sfc-gh-mvashishtha sfc-gh-mvashishtha is a code owner automatically assigned from snowflakedb/snowpark-pandas-api

+1 more reviewer

@sfc-gh-nkrishna sfc-gh-nkrishna sfc-gh-nkrishna approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs snowpark-pandas

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sfc-gh-helmeleegy @sfc-gh-nkrishna @sfc-gh-jkew