Skip to content

remove types and dependency#3950

Merged
sfc-gh-mkeller merged 1 commit intomainfrom
mkeller/remove-snowflake.core-types
Oct 24, 2025
Merged

remove types and dependency#3950
sfc-gh-mkeller merged 1 commit intomainfrom
mkeller/remove-snowflake.core-types

Conversation

@sfc-gh-mkeller
Copy link
Collaborator

@sfc-gh-mkeller sfc-gh-mkeller commented Oct 23, 2025

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-2267482

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines
  3. Please describe how your code solves the related issue.

    This PR follows up on SNOW-2267482 replacing SnowAPI calls with SQL calls #3942 and completely removes the dependency on snowflake.core by introducing a class that will look like the old pydantic classes. ImmutableAttrDict is a class that's like a dictionary, but allows attr access to its values and becomes frozen after creation, the types from snowflake.core were replaced by child classes of ImmutableAttrDict.

@sfc-gh-mkeller sfc-gh-mkeller requested review from a team as code owners October 23, 2025 22:31
@sfc-gh-mkeller sfc-gh-mkeller force-pushed the mkeller/remove-snowflake.core-types branch from 911c981 to aaccc32 Compare October 23, 2025 22:34
CHANGELOG.md Outdated

- The default maximum length for inferred StringType columns during schema inference in `DataFrameReader.dbapi` is now increased from 16MB to 128MB in parquet file based ingestion.
- Catalog API now uses SQL commands instead of SnowAPI calls. This new implementation is more reliable now.
- Catalog API no longer uses types declared in `snowflake.core` and therefore this dependency was removed.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not going to catch the 1.41.0 release right? shall we move it to 1.42?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is up to your discretion. You tell me! 😄
The API was marked experimental and @sfc-gh-aalam was okay with changing the types because of it.

Base automatically changed from mkeller/python-api-removal to main October 23, 2025 23:17
@sfc-gh-mkeller sfc-gh-mkeller force-pushed the mkeller/remove-snowflake.core-types branch from aaccc32 to 5d3800b Compare October 23, 2025 23:27
"pytest-assume", # sql counter check
"decorator", # sql counter check
"tox", # used for setting up testing environments
"snowflake.core>=1.0.0, <2", # Catalog
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also check if we need this update in recipe/meta.yaml

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not there!

@sfc-gh-mkeller sfc-gh-mkeller force-pushed the mkeller/remove-snowflake.core-types branch from 0bc7ec3 to b8faa64 Compare October 24, 2025 00:42
@sfc-gh-mkeller sfc-gh-mkeller force-pushed the mkeller/remove-snowflake.core-types branch from b8faa64 to 75b4e42 Compare October 24, 2025 01:00
@sfc-gh-mkeller sfc-gh-mkeller merged commit b7ad653 into main Oct 24, 2025
64 of 71 checks passed
@sfc-gh-mkeller sfc-gh-mkeller deleted the mkeller/remove-snowflake.core-types branch October 24, 2025 06:37
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants