Merged
Conversation
911c981 to
aaccc32
Compare
CHANGELOG.md
Outdated
|
|
||
| - The default maximum length for inferred StringType columns during schema inference in `DataFrameReader.dbapi` is now increased from 16MB to 128MB in parquet file based ingestion. | ||
| - Catalog API now uses SQL commands instead of SnowAPI calls. This new implementation is more reliable now. | ||
| - Catalog API no longer uses types declared in `snowflake.core` and therefore this dependency was removed. |
Collaborator
There was a problem hiding this comment.
this is not going to catch the 1.41.0 release right? shall we move it to 1.42?
Collaborator
Author
There was a problem hiding this comment.
This is up to your discretion. You tell me! 😄
The API was marked experimental and @sfc-gh-aalam was okay with changing the types because of it.
aaccc32 to
5d3800b
Compare
sfc-gh-yuwang
approved these changes
Oct 23, 2025
sfc-gh-aalam
approved these changes
Oct 23, 2025
| "pytest-assume", # sql counter check | ||
| "decorator", # sql counter check | ||
| "tox", # used for setting up testing environments | ||
| "snowflake.core>=1.0.0, <2", # Catalog |
Contributor
There was a problem hiding this comment.
can you also check if we need this update in recipe/meta.yaml
Collaborator
Author
There was a problem hiding this comment.
It's not there!
0bc7ec3 to
b8faa64
Compare
b8faa64 to
75b4e42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-2267482
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
This PR follows up on SNOW-2267482 replacing SnowAPI calls with SQL calls #3942 and completely removes the dependency on
snowflake.coreby introducing a class that will look like the old pydantic classes.ImmutableAttrDictis a class that's like a dictionary, but allows attr access to its values and becomes frozen after creation, the types fromsnowflake.corewere replaced by child classes ofImmutableAttrDict.