-
Notifications
You must be signed in to change notification settings - Fork 141
SNOW-2872192: Support targeted delete-insert in save_as_table #4031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sfc-gh-mayliu
merged 5 commits into
main
from
SNOW-2872192-saveAsTable-targeted-delete-insert
Dec 11, 2025
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
53dedc7
Support override_condition in save_as_table for targeted delete-insert
sfc-gh-mayliu 557d260
rename param to overwrite_condition; can work with both Append and Ov…
sfc-gh-mayliu 7a463f9
Add AST support
sfc-gh-mayliu eaf4292
overwrite_condition should only work with overwrite mode, reverting s…
sfc-gh-mayliu afe2dbe
elaborate selective overwrite behavior in docstring
sfc-gh-mayliu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| // N.B. This file is generated by `//ir-dsl-c`. DO NOT EDIT! | ||
| // Generated from `{[email protected]:snowflakedb/snowflake.git}/Snowpark/ast`. | ||
| // Generated from `{[email protected]:snowflake-eng/snowflake.git}/Snowpark/ast`. | ||
|
|
||
| syntax = "proto3"; | ||
|
|
||
|
|
@@ -987,7 +987,7 @@ message DataframeCollect { | |
| repeated Tuple_String_String statement_params = 7; | ||
| } | ||
|
|
||
| // dataframe-io.ir:165 | ||
| // dataframe-io.ir:167 | ||
| message DataframeCopyIntoTable { | ||
| repeated Tuple_String_Expr copy_options = 1; | ||
| Expr df = 2; | ||
|
|
@@ -1011,7 +1011,7 @@ message DataframeCount { | |
| repeated Tuple_String_String statement_params = 4; | ||
| } | ||
|
|
||
| // dataframe-io.ir:148 | ||
| // dataframe-io.ir:150 | ||
| message DataframeCreateOrReplaceDynamicTable { | ||
| repeated Expr clustering_keys = 1; | ||
| google.protobuf.StringValue comment = 2; | ||
|
|
@@ -1030,7 +1030,7 @@ message DataframeCreateOrReplaceDynamicTable { | |
| string warehouse = 15; | ||
| } | ||
|
|
||
| // dataframe-io.ir:139 | ||
| // dataframe-io.ir:141 | ||
| message DataframeCreateOrReplaceView { | ||
| google.protobuf.StringValue comment = 1; | ||
| bool copy_grants = 2; | ||
|
|
@@ -2685,7 +2685,7 @@ message WindowSpecRowsBetween { | |
| WindowSpecExpr wnd = 4; | ||
| } | ||
|
|
||
| // dataframe-io.ir:116 | ||
| // dataframe-io.ir:118 | ||
| message WriteCopyIntoLocation { | ||
| bool block = 1; | ||
| repeated Tuple_String_Expr copy_options = 2; | ||
|
|
@@ -2704,7 +2704,7 @@ message WriteCopyIntoLocation { | |
| Expr writer = 15; | ||
| } | ||
|
|
||
| // dataframe-io.ir:123 | ||
| // dataframe-io.ir:125 | ||
| message WriteCsv { | ||
| bool block = 1; | ||
| repeated Tuple_String_Expr copy_options = 2; | ||
|
|
@@ -2731,15 +2731,15 @@ message WriteFile { | |
| } | ||
| } | ||
|
|
||
| // dataframe-io.ir:129 | ||
| // dataframe-io.ir:131 | ||
| message WriteInsertInto { | ||
| bool overwrite = 1; | ||
| SrcPosition src = 2; | ||
| NameRef table_name = 3; | ||
| Expr writer = 4; | ||
| } | ||
|
|
||
| // dataframe-io.ir:125 | ||
| // dataframe-io.ir:127 | ||
| message WriteJson { | ||
| bool block = 1; | ||
| repeated Tuple_String_Expr copy_options = 2; | ||
|
|
@@ -2773,7 +2773,7 @@ message WritePandas { | |
| string table_type = 13; | ||
| } | ||
|
|
||
| // dataframe-io.ir:127 | ||
| // dataframe-io.ir:129 | ||
| message WriteParquet { | ||
| bool block = 1; | ||
| repeated Tuple_String_Expr copy_options = 2; | ||
|
|
@@ -2790,7 +2790,7 @@ message WriteParquet { | |
| Expr writer = 13; | ||
| } | ||
|
|
||
| // dataframe-io.ir:121 | ||
| // dataframe-io.ir:123 | ||
| message WriteSave { | ||
| bool block = 1; | ||
| repeated Tuple_String_Expr copy_options = 2; | ||
|
|
@@ -2821,9 +2821,11 @@ message WriteTable { | |
| repeated Tuple_String_Expr iceberg_config = 10; | ||
| google.protobuf.Int64Value max_data_extension_time = 11; | ||
| SaveMode mode = 12; | ||
| SrcPosition src = 13; | ||
| repeated Tuple_String_String statement_params = 14; | ||
| NameRef table_name = 15; | ||
| string table_type = 16; | ||
| Expr writer = 17; | ||
| Expr overwrite_condition = 13; | ||
| SrcPosition src = 14; | ||
| repeated Tuple_String_String statement_params = 15; | ||
| google.protobuf.BoolValue table_exists = 16; | ||
| NameRef table_name = 17; | ||
| string table_type = 18; | ||
| Expr writer = 19; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.