Skip to content

Conversation

@sfc-gh-bkogan
Copy link
Contributor

@sfc-gh-bkogan sfc-gh-bkogan commented Jan 22, 2026

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-2185194

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines
  3. Please describe how your code solves the related issue.

    This adds support for the DECFLOAT numeric data type, which is a decimal floating-point number. decimal.Decimal literals are still inferred as NUMBER type. Not sure if we can change that in any way without being backwards incompatible. Users can use lit with an explicit datatype argument for now.

    From reading the connector PR, it seems that the user is expected to set the decimal context to precision 38 in order to preserve the precision stored on the server. I kept that behavior here.

@github-actions github-actions bot added the local testing Local Testing issues/PRs label Jan 22, 2026
@sfc-gh-bkogan sfc-gh-bkogan requested a review from a team January 23, 2026 21:28
@sfc-gh-bkogan sfc-gh-bkogan marked this pull request as ready for review January 23, 2026 21:28
@sfc-gh-bkogan sfc-gh-bkogan requested review from a team as code owners January 23, 2026 21:28
@sfc-gh-yuwang
Copy link
Collaborator

Hi @sfc-gh-heshah , can you help review the IR part of this PR? Thank you!

Copy link
Collaborator

@sfc-gh-heshah sfc-gh-heshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from AST perspective, thanks @sfc-gh-bkogan!

@sfc-gh-bkogan sfc-gh-bkogan merged commit 9e16b0e into main Jan 28, 2026
45 of 49 checks passed
@sfc-gh-bkogan sfc-gh-bkogan deleted the bkogan-decfloat branch January 28, 2026 19:06
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

local testing Local Testing issues/PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants