-
Notifications
You must be signed in to change notification settings - Fork 142
Add support for DECFLOAT type #4055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-bkogan
commented
Jan 22, 2026
c41d87d to
b6af7be
Compare
Collaborator
|
Hi @sfc-gh-heshah , can you help review the IR part of this PR? Thank you! |
sfc-gh-yuwang
approved these changes
Jan 27, 2026
sfc-gh-heshah
approved these changes
Jan 28, 2026
Collaborator
sfc-gh-heshah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from AST perspective, thanks @sfc-gh-bkogan!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-2185194
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
This adds support for the DECFLOAT numeric data type, which is a decimal floating-point number.
decimal.Decimalliterals are still inferred asNUMBERtype. Not sure if we can change that in any way without being backwards incompatible. Users can uselitwith an explicitdatatypeargument for now.From reading the connector PR, it seems that the user is expected to set the
decimalcontext to precision 38 in order to preserve the precision stored on the server. I kept that behavior here.