Skip to content

NOSNOW: Expect ICEBERG_VERSION = 2 in tests with Iceberg get_ddl assertions #4136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sfc-gh-helmeleegy merged 2 commits into from
Mar 25, 2026
Merged

NOSNOW: Expect ICEBERG_VERSION = 2 in tests with Iceberg get_ddl assertions #4136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b43ce3
NOSNOW: Expect ICEBERG_VERSION = 2 in tests with Iceberg get_ddl asse…
sfc-gh-helmeleegy Mar 25, 2026
4f3bf65
Apply suggestion from @sfc-gh-joshi
sfc-gh-helmeleegy Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/integ/scala/test_dataframe_copy_into.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ def test_copy_into_csv_iceberg(
ddl = session._run_query(f"select get_ddl('table', '{test_table_name}')")
assert (
ddl[0][0]
== f"create or replace ICEBERG TABLE {test_table_name} (\n\tA LONG,\n\tB STRING,\n\tC DOUBLE\n)\n PARTITION BY (B, BUCKET(10, A), TRUNCATE(3, B))\n EXTERNAL_VOLUME = 'PYTHON_CONNECTOR_ICEBERG_EXVOL'\n CATALOG = 'SNOWFLAKE'\n BASE_LOCATION = 'snowpark_python_tests/';"
== f"create or replace ICEBERG TABLE {test_table_name} (\n\tA LONG,\n\tB STRING,\n\tC DOUBLE\n)\n PARTITION BY (B, BUCKET(10, A), TRUNCATE(3, B))\n EXTERNAL_VOLUME = 'PYTHON_CONNECTOR_ICEBERG_EXVOL'\n ICEBERG_VERSION = 2\n CATALOG = 'SNOWFLAKE'\n BASE_LOCATION = 'snowpark_python_tests/';"
)
# Check that a copy_into works on the newly created table.
df.copy_into_table(test_table_name)
Expand Down
2 changes: 1 addition & 1 deletion tests/integ/scala/test_dataframe_writer_suite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ def test_iceberg_partition_by(session, local_testing_mode):
ddl[0][0] == f"create or replace ICEBERG TABLE {table_name_1} (\n\t"
f"A STRING,\n\tB LONG\n)\n "
f"PARTITION BY (B)\n "
f"EXTERNAL_VOLUME = 'PYTHON_CONNECTOR_ICEBERG_EXVOL'\n CATALOG = 'SNOWFLAKE';"
f"EXTERNAL_VOLUME = 'PYTHON_CONNECTOR_ICEBERG_EXVOL'\n ICEBERG_VERSION = 2\n CATALOG = 'SNOWFLAKE';"
)

finally:
Expand Down
4 changes: 2 additions & 2 deletions tests/integ/scala/test_datatype_suite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,7 +560,7 @@ def test_structured_dtypes_iceberg(
assert save_ddl[0][0] == (
f"create or replace ICEBERG TABLE {table_name.upper()} (\n\t"
"MAP MAP(STRING, LONG),\n\tOBJ OBJECT(A STRING, b DOUBLE),\n\tARR ARRAY(DOUBLE)\n)\n "
"EXTERNAL_VOLUME = 'PYTHON_CONNECTOR_ICEBERG_EXVOL'\n CATALOG = 'SNOWFLAKE'\n "
"EXTERNAL_VOLUME = 'PYTHON_CONNECTOR_ICEBERG_EXVOL'\n ICEBERG_VERSION = 2\n CATALOG = 'SNOWFLAKE'\n "
"BASE_LOCATION = 'python_connector_merge_gate/';"
)

Expand Down Expand Up @@ -588,7 +588,7 @@ def test_structured_dtypes_iceberg(
f"create or replace dynamic iceberg table {dynamic_table_name}(\n\tMAP,\n\tOBJ,\n\tARR\n)"
" target_lag = '16 hours, 40 minutes' refresh_mode = AUTO initialize = ON_CREATE "
f"warehouse = {warehouse} external_volume = 'PYTHON_CONNECTOR_ICEBERG_EXVOL' "
"catalog = 'SNOWFLAKE' base_location = 'python_connector_merge_gate/' \n as "
"catalog = 'SNOWFLAKE' ICEBERG_VERSION = 2 base_location = 'python_connector_merge_gate/' \n as "
f"SELECT * \n FROM (\n SELECT * FROM {formatted_table_name}\n);"
)

Expand Down
Loading