Merged
Conversation
Oguzhan Unlu (oguzhanunlu)
force-pushed
the
fix/flaky-metrics-spec-test
branch
from
8160dac to
2583dfa
Compare
Oguzhan Unlu (oguzhanunlu)
force-pushed
the
fix/flaky-metrics-spec-test
branch
from
2583dfa to
5da67ae
Compare
Oguzhan Unlu (oguzhanunlu)
force-pushed
the
fix/flaky-metrics-spec-test
branch
2 times, most recently
from
d8b0032 to
b7288f7
Compare
Ian Streeter (istreeter)
approved these changes
Jan 8, 2026
Collaborator
Author
|
I saw another flaky test failure debugging this too |
The test was failing intermittently with: Some(1800000000 microseconds) is not None At exactly 30 minutes, a new batch could arrive but not yet be processed, causing currentStreamLatency to report the batch's latency. Adding 500ms offset avoids landing on batch boundaries.
Oguzhan Unlu (oguzhanunlu)
changed the title
modules/it/src/test/scala/com/snowplowanalytics/snowplow/runtime/MetricsSpec.scala
Outdated
Show resolved
Hide resolved
Ian Streeter (istreeter)
approved these changes
Jan 8, 2026
modules/it/src/test/scala/com/snowplowanalytics/snowplow/runtime/MetricsSpec.scala
Outdated
Show resolved
Hide resolved
Use the same pattern as enrich-private: container lifecycle is managed via Resource with a generous ResourceTimeout for startup, rather than manually starting in beforeAll and stopping in afterAll.
Ian Streeter (istreeter)
approved these changes
Jan 8, 2026
Oguzhan Unlu (oguzhanunlu)
added a commit
that referenced
this pull request
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pulling
dblworks/statsd:v0.10.1image was part of test timeout for MetricsSpec, so changes are needed together