Adding aggregated engagement tracking to snowplow.js#1290
Adding aggregated engagement tracking to snowplow.js#1290jrpeck1989 wants to merge 3 commits intomainfrom
Conversation
✅ Deploy Preview for snowplow-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
TODOBefore this can be merged, a |
mscwilson
left a comment
mscwilson
left a comment
There was a problem hiding this comment.
needs tidying up from testing but otherwise lgtm
| cookieDomain: `.${domain[1]}.${domain[0]}`, | ||
| cookieName, | ||
| cookieSameSite: 'Lax', | ||
| keepalive: true, |
There was a problem hiding this comment.
This is an important point. It uses the keep alive functionality of the Fetch API that means even after a window is closed or you've navigated away, the browser will still complete the request. This was the problem with the Beacon API which made this entire aggregated page ping logic so flaky, and why I want to try this method out.
| newTracker( | ||
| 'snplow5', | ||
| 'https://collector.snowplow.io', | ||
| // 'https://collector.snowplow.io', |
There was a problem hiding this comment.
fix these commented out bits please
|
what's happening with this PR? |
I need to have a meeting with Ostap to go over the implementation and verify it won't affect other tracking that is already in place |
|
hey @pif , do these changes look ok to you? |
2 participants
No description provided.