Skip to content

Iceberg REST seal of approval#1617

Open
stanch wants to merge 1 commit intomainfrom
iceberg-rest
Open

Iceberg REST seal of approval#1617
stanch wants to merge 1 commit intomainfrom
iceberg-rest

Conversation

@stanch
Copy link
Contributor

@stanch stanch commented Feb 6, 2026

What changed?

Documented Iceberg + REST as a supported option.

Why?

Because it is now supported in the UI.

@stanch stanch requested a review from istreeter February 6, 2026 16:16
@netlify
Copy link

netlify bot commented Feb 6, 2026

Deploy Preview for snowplow-docs ready!

Name Link
🔨 Latest commit 54cbe34
🔍 Latest deploy log https://app.netlify.com/projects/snowplow-docs/deploys/698613c44903370008e9d4bc
😎 Deploy Preview https://deploy-preview-1617--snowplow-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 14 (🔴 down 10 from production)
Accessibility: 91 (no change from production)
Best Practices: 92 (no change from production)
SEO: 95 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@claude
Copy link

claude bot commented Feb 6, 2026

Writing Quality Review

Thank you for documenting the Iceberg REST catalog support. Here's feedback on style guide compliance:

Issues to fix

1. Footnote formatting in table
The footnote "¹The REST catalog has only been tested with the Snowflake Open Catalog implementation." should be placed below the table as regular text, not as a footnote. Per the style guide, use straightforward prose without special notation.

Change to:

| Catalog | AWS | GCP |
| ------- | --- | --- |
| Glue | :white_check_mark: | :x: |
| REST | :white_check_mark: | :white_check_mark: |

The REST catalog has only been tested with the Snowflake Open Catalog implementation.

2. Emoji usage in table
The style guide states: "Use emojis only for information (✅ or ❌ in tables)." Replace :white_check_mark: and :x: with ✅ and ❌ respectively.

3. Missing explanatory paragraph before list
Per the style guide: "Precede every heading and list with at least one paragraph of prose." The sentence "We currently support the following catalogs:" should be expanded into a full paragraph before the table explaining what catalog options are available and why this matters.

4. Inconsistent capitalization in admonition
In the new note admonition, "Catalog options" should follow sentence case consistently with the rest of the documentation.

5. Incomplete sentence in admonition
"The instructions below are not necessary when using Snowflake Open Catalog." This could be clearer. Consider: "The maintenance instructions below are not required when using the Snowflake Open Catalog."

6. List item formatting
In the REST tab, the list items should be rephrased for consistency:

  • "Specify your Snowflake Open Catalog account id" → "Specify your Snowflake Open Catalog account ID" (capitalize ID per style guide for acronyms)
  • Consider parallel structure with the Glue tab items

Minor suggestions

  • Consider whether "Snowflake Open Catalog" should be consistently styled throughout (it appears with different capitalization in different contexts)
  • The phrase "has only been tested" implies temporal limitation. Consider "is tested with" or document the specific implementation scope without temporal language per the style guide's guidance to stay in present tense and avoid "currently".

@stanch stanch requested a review from mscwilson February 6, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant