Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements real-time streaming of task output and improves code formatting consistency throughout the codebase. The main change switches from batch output collection to streaming output line-by-line as tasks execute.
Key changes:
- Modified
execute_osto stream stdout/stderr in real-time using threads and buffered readers instead of waiting for process completion - Added
get_task_summary_strfunction to print only summary information after streaming output - Reformatted code throughout using
rustfmtfor consistent code style
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/main.rs | Added get_task_summary_str function, updated result printing logic to use new summary function, and applied consistent code formatting |
| src/factotum/executor/execution_strategy/mod.rs | Refactored execute_os to stream stdout/stderr in real-time using threads and buffered readers, added necessary imports |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
e100aa1 to
ec18dbb
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
e89e933 to
50c7e54
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
c17d845 to
4276362
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Greg Leonard (greg-el)
left a comment
There was a problem hiding this comment.
LGTM! Couple of style nitpicks, but nothing to block over.
7df364b to
fed44c9
Compare
fed44c9 to
8ca5914
Compare
No description provided.