Bump web-vitals version#1412
Merged
Jethro Nederhof (jethron) merged 1 commit intosnowplow:release/4.3.2from Mar 10, 2025
Merged
Bump web-vitals version#1412Jethro Nederhof (jethron) merged 1 commit intosnowplow:release/4.3.2from
Jethro Nederhof (jethron) merged 1 commit intosnowplow:release/4.3.2from
Conversation
From ~3 to ~4. Also make the metric interfaces optional in preparation for v5, which will remove the (deprecated in v4) `onFID` method. The FID metric is already optional in the [schema](https://iglucentral.com/?q=web_vitals), so there should be no breaking change here when this metric becomes unavailable. We assume if the user is using the library themselves they would be manually loading it and telling us not to via: - `loadVitalsScript: false` - `webVitalsSource` override So we don't consider this a breaking change unless a user is relying on us to load v3 and with this update we start loading v4 (which has some [breaking changes](https://github.com/GoogleChrome/web-vitals/blob/main/docs/upgrading-to-v4.md)). Users in this situation can set `webVitalsSource` to continue loading v3. When v5 is released, users can opt-in to using it by specifying a v5 source for `webVitalsSource`, which should work as expected with these changes until we update the plugin's default source to be v5. Closes snowplow#1411
Jethro Nederhof (jethron)
requested review from
Peter Perlepes (igneel64) and
Matus Tomlein (matus-tomlein)
Matus Tomlein (matus-tomlein)
approved these changes
Mar 7, 2025
Contributor
Matus Tomlein (matus-tomlein)
left a comment
Matus Tomlein (matus-tomlein)
left a comment
There was a problem hiding this comment.
This looks good to me, but will defer to Peter Perlepes (@igneel64) as he is the expert here.
Also please run rush change.
Peter Perlepes (igneel64)
approved these changes
Mar 10, 2025
Jethro Nederhof (jethron)
merged commit 9853660
into
snowplow:release/4.3.2
1 check failed
Greg Leonard (greg-el)
pushed a commit
that referenced
this pull request
Mar 20, 2025
From ~3 to ~4. Also make the metric interfaces optional in preparation for v5, which will remove the (deprecated in v4) `onFID` method. The FID metric is already optional in the [schema](https://iglucentral.com/?q=web_vitals), so there should be no breaking change here when this metric becomes unavailable. We assume if the user is using the library themselves they would be manually loading it and telling us not to via: - `loadVitalsScript: false` - `webVitalsSource` override So we don't consider this a breaking change unless a user is relying on us to load v3 and with this update we start loading v4 (which has some [breaking changes](https://github.com/GoogleChrome/web-vitals/blob/main/docs/upgrading-to-v4.md)). Users in this situation can set `webVitalsSource` to continue loading v3. When v5 is released, users can opt-in to using it by specifying a v5 source for `webVitalsSource`, which should work as expected with these changes until we update the plugin's default source to be v5. Closes #1411
|
Thank you so much for this! Let us know if you run into any problems. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From ~3 to ~4. Also make the metric interfaces optional in preparation for v5, which will remove the (deprecated in v4)
onFIDmethod.The FID metric is already optional in the schema, so there should be no breaking change here when this metric becomes unavailable.
We assume if the user is using the library themselves they would be manually loading it and telling us not to via:
loadVitalsScript: falsewebVitalsSourceoverrideSo I don't consider this a breaking change unless a user is relying on us to load v3 and with this update we start loading v4 (which has some breaking changes). Users in this situation can set
webVitalsSourcemanually to continue loading v3 until they can support v4.When v5 is released, users can opt-in to using it by specifying a v5 source for
webVitalsSource, which should work as expected with these changes until we update the plugin's default source to be v5.v4 removes the IIFE-version of the library's global var type definitions (
webVitals: WebVitalsGlobal), so we now declare it ourselves.Closes #1411