Truncate browser context hardwareConcurrency value#1446
Merged
Jethro Nederhof (jethron) merged 1 commit intorelease/4.6.6from Aug 19, 2025
Merged
Truncate browser context hardwareConcurrency value#1446Jethro Nederhof (jethron) merged 1 commit intorelease/4.6.6from
Jethro Nederhof (jethron) merged 1 commit intorelease/4.6.6from
Conversation
We have received reports of some UAs providing this value as a floating point rather than integral value (contrary to the web standards). This causes events from those agents to be invalid because the schema requires it to be an integer. To meet the documented behavior and schema expectations, floor the value to ensure it is a whole integer. If the UA doesn't have this value, Math.floor should return NaN which we will turn into undefined to exclude from the event. This will also occur with '0', which shouldn't be a valid value according to the standard anyway so is deemed acceptable. Issue: AISP-629
Matus Tomlein (matus-tomlein)
approved these changes
Aug 19, 2025
Jethro Nederhof (jethron)
merged commit d395c12
into
release/4.6.6
5 of 6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have received reports of some UAs providing this value as a floating point rather than integral value (contrary to the web standards). This causes events from those agents to be invalid because the schema requires it to be an integer. To meet the documented behavior and schema expectations, floor the value to ensure it is a whole integer. If the UA doesn't have this value, Math.floor should return NaN which we will turn into undefined to exclude from the event. This will also occur with '0', which shouldn't be a valid value according to the standard anyway so is deemed acceptable.
Issue: AISP-629