Skip to content

Kartikdedhia login handler #1488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Kartikdedhia login handler #1488

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a5f5405
Update package.json
kartikdedhia Apr 29, 2022
9da6486
Update package.json
kartikdedhia May 2, 2022
baf6220
Merge branch 'snyk-labs:main' into master
kartikdedhia Jul 19, 2022
b9ee28d
Update index.js
kartikdedhia Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions routes/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,19 +35,24 @@ exports.index = function (req, res, next) {
};

exports.loginHandler = function (req, res, next) {
if (validator.isEmail(req.body.username)) {
User.find({ username: req.body.username, password: req.body.password }, function (err, users) {
const username = req.body.username; // Get username directly from request body

if (validator.isEmail(username)) {
// Potential NoSQL Injection Point! Directly embedding user input in the query
const query = { username: username, password: req.body.password };

User.find(query, function (err, users) {
if (users.length > 0) {
const redirectPage = req.body.redirectPage
const session = req.session
const username = req.body.username
return adminLoginSuccess(redirectPage, session, username, res)
const redirectPage = req.body.redirectPage;
const session = req.session;
const password = "password123";
return adminLoginSuccess(redirectPage, session, username, res);
} else {
return res.status(401).send()
return res.status(401).send();
}
});
} else {
return res.status(401).send()
return res.status(401).send();
}
};

Expand Down