Reapply "Merge pull request #40 from snyk/feat(reachability)/pass-loc… #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) ✅ code/snyk check is complete. No issues have been found. (View Details) |
paulrosca-snyk
force-pushed
the
feat/rechability-local-policy
branch
from
f2d6bb5 to
ae9e382
Compare
…al-policy-to-test" This reverts commit d96f1f4.
paulrosca-snyk
force-pushed
the
feat/rechability-local-policy
branch
from
ae9e382 to
fde4e5d
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| return nil, errFactory.NewFeatureNotPermittedError(FeatureFlagRiskScore) | ||
| } | ||
| return nil, errFactory.NewFeatureNotPermittedError(FeatureFlagRiskScoreInCLI) | ||
| } |
There was a problem hiding this comment.
Bug: Feature Flag Validation Scope Error
Moving the risk score feature flag validation from setupDefaultTestFlow to OSWorkflow introduced two bugs:
- The validation now incorrectly applies to the SBOM reachability flow, causing feature flag errors despite SBOM not using risk score thresholds.
- The moved logic in
OSWorkflowreferences undefined variables (riskScoreThreshold,riskScoreFFsEnabled,ffRiskScore), which were not re-declared in the new scope.
There was a problem hiding this comment.
- The validation should apply to the SBOM flow as well if the user provides the
--risk-score-threshold. - The variables are declared a few lines above.
bsalomon-snyk
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…al-policy-to-test"
This reverts commit d96f1f4.