Skip to content

wip #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

wip #46

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,6 @@
### Local development ###
# Local build system configuration
/local.mk
.idea

node_modules
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ require (
github.com/google/uuid v1.6.0
github.com/muesli/termenv v0.15.2
github.com/oapi-codegen/runtime v1.1.1
github.com/puzpuzpuz/xsync v1.5.2
github.com/rs/zerolog v1.34.0
github.com/snyk/code-client-go v1.21.3
github.com/snyk/error-catalog-golang-public v0.0.0-20250625135845-2d6f9a31f318
Expand Down Expand Up @@ -81,7 +82,6 @@ require (
github.com/pkg/browser v0.0.0-20210911075715-681adbf594b8 // indirect
github.com/pkg/errors v0.9.1 // indirect
github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 // indirect
github.com/puzpuzpuz/xsync v1.5.2 // indirect
github.com/rivo/uniseg v0.4.7 // indirect
github.com/rogpeppe/go-internal v1.14.1 // indirect
github.com/sabhiram/go-gitignore v0.0.0-20210923224102-525f6e181f06 // indirect
Expand Down
237 changes: 237 additions & 0 deletions internal/fileupload/client.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,237 @@
package fileupload

import (
"context"
"fmt"
"github.com/snyk/cli-extension-os-flows/internal/fileupload/filters"
"net/http"
"os"
"path/filepath"
"runtime"

"github.com/google/uuid"
"github.com/puzpuzpuz/xsync"

listsources "github.com/snyk/cli-extension-os-flows/internal/files"
"github.com/snyk/cli-extension-os-flows/internal/fileupload/uploadrevision"
)

// Config contains configuration for the file upload client.
type Config struct {
BaseURL string
OrgID OrgID
}

// Client provides high-level file upload functionality.
type Client struct {
uploadRevisionSealableClient uploadrevision.SealableClient
filtersClient filters.Client
cfg Config
filters Filters
}

// NewClient creates a new high-level file upload client.
func NewClient(httpClient *http.Client, cfg Config, opts ...Option) *Client {
client := &Client{
cfg: cfg,
filters: Filters{
supportedExtensions: xsync.NewMapOf[bool](),
supportedConfigFiles: xsync.NewMapOf[bool](),
},
}

for _, opt := range opts {
opt(client)
}

if client.uploadRevisionSealableClient == nil {
client.uploadRevisionSealableClient = uploadrevision.NewClient(uploadrevision.Config{
BaseURL: cfg.BaseURL,
}, uploadrevision.WithHTTPClient(httpClient))
}

if client.filtersClient == nil {
client.filtersClient = filters.NewDeeproxyClient(filters.Config{
BaseURL: cfg.BaseURL,
}, filters.WithHTTPClient(httpClient))
}

return client
}

func (c *Client) loadFilters(ctx context.Context) error {
c.filters.once.Do(func() {
filtersResp, err := c.filtersClient.GetFilters(ctx, c.cfg.OrgID)
if err != nil {
c.filters.initErr = err
return
}

for _, ext := range filtersResp.Extensions {
c.filters.supportedExtensions.Store(ext, true)
}
for _, configFile := range filtersResp.ConfigFiles {
// .gitignore and .dcignore should not be uploaded
// (https://github.com/snyk/code-client/blob/d6f6a2ce4c14cb4b05aa03fb9f03533d8cf6ca4a/src/files.ts#L138)
if configFile == ".gitignore" || configFile == ".dcignore" {
continue
}
c.filters.supportedConfigFiles.Store(configFile, true)
}
})
return c.filters.initErr
}

// createFileFilter creates a filter function based on the current filtering configuration.
// Returns nil if filtering should be skipped, otherwise returns a function that evaluates files.
func (c *Client) createFileFilter(ctx context.Context) (func(string) bool, error) {
if err := c.loadFilters(ctx); err != nil {
return nil, fmt.Errorf("failed to load deeproxy filters: %w", err)
}

return func(path string) bool {
fileExt := filepath.Ext(path)
fileName := filepath.Base(path)
_, isSupportedExtension := c.filters.supportedExtensions.Load(fileExt)
_, isSupportedConfigFile := c.filters.supportedConfigFiles.Load(fileName)
return isSupportedExtension || isSupportedConfigFile
}, nil
}

func (c *Client) uploadPaths(ctx context.Context, revID RevisionID, rootPath string, paths []string) error {
files := make([]uploadrevision.UploadFile, 0, c.uploadRevisionSealableClient.GetLimits().FileCountLimit)
defer func() {
for _, file := range files {
file.File.Close()
}
}()

for _, pth := range paths {
relPth, err := filepath.Rel(rootPath, pth)
if err != nil {
return fmt.Errorf("failed to get relative path for %s: %w", pth, err)
}

f, err := os.Open(pth)
if err != nil {
return fmt.Errorf("failed to open file %s: %w", pth, err)
}

files = append(files, uploadrevision.UploadFile{
Path: relPth,
File: f,
})
}

err := c.uploadRevisionSealableClient.UploadFiles(ctx, c.cfg.OrgID, revID, files)
if err != nil {
return fmt.Errorf("failed to upload files: %w", err)
}

return nil
}

// addPathsToRevision adds multiple file paths to an existing revision.
func (c *Client) addPathsToRevision(ctx context.Context, revisionID RevisionID, rootPath string, pathsChan <-chan string, opts UploadOptions) error {
var chunks <-chan []string

if opts.SkipFiltering {
chunks = chunkChan(pathsChan, c.uploadRevisionSealableClient.GetLimits().FileCountLimit)
} else {
filter, err := c.createFileFilter(ctx)
if err != nil {
return err
}
chunks = chunkChanFiltered(pathsChan, c.uploadRevisionSealableClient.GetLimits().FileCountLimit, filter)
}

for chunk := range chunks {
err := c.uploadPaths(ctx, revisionID, rootPath, chunk)
if err != nil {
return err
}
}

return nil
}

// CreateRevision creates a new revision and returns its ID.
func (c *Client) CreateRevision(ctx context.Context) (RevisionID, error) {
revision, err := c.uploadRevisionSealableClient.CreateRevision(ctx, c.cfg.OrgID)
if err != nil {
return uuid.Nil, fmt.Errorf("failed to create revision: %w", err)
}
return revision.Data.ID, nil
}

// AddFileToRevision adds a single file to an existing revision.
func (c *Client) AddFileToRevision(ctx context.Context, revisionID RevisionID, filePath string, opts UploadOptions) error {
writableChan := make(chan string, 1)
writableChan <- filePath
close(writableChan)

return c.addPathsToRevision(ctx, revisionID, filepath.Dir(filePath), writableChan, opts)
}

// AddDirToRevision adds a directory and all its contents to an existing revision.
func (c *Client) AddDirToRevision(ctx context.Context, revisionID RevisionID, dirPath string, opts UploadOptions) error {
sources, err := listsources.ForPath(dirPath, nil, runtime.NumCPU())
if err != nil {
return fmt.Errorf("failed to list files in directory %s: %w", dirPath, err)
}

return c.addPathsToRevision(ctx, revisionID, dirPath, sources, opts)
}

// SealRevision seals a revision, making it immutable.
func (c *Client) SealRevision(ctx context.Context, revisionID RevisionID) error {
_, err := c.uploadRevisionSealableClient.SealRevision(ctx, c.cfg.OrgID, revisionID)
if err != nil {
return fmt.Errorf("failed to seal revision: %w", err)
}
return nil
}

// CreateRevisionFromPaths uploads multiple paths (files or directories), returning a revision ID.
// This is a convenience method that creates, uploads, and seals a revision.
func (c *Client) CreateRevisionFromPaths(ctx context.Context, paths []string, opts UploadOptions) (RevisionID, error) {
revisionID, err := c.CreateRevision(ctx)
if err != nil {
return uuid.Nil, err
}

for _, pth := range paths {
info, err := os.Stat(pth)
if err != nil {
return uuid.Nil, fmt.Errorf("failed to stat path %s: %w", pth, err)
}

if info.IsDir() {
if err := c.AddDirToRevision(ctx, revisionID, pth, opts); err != nil {
return uuid.Nil, fmt.Errorf("failed to add directory %s: %w", pth, err)
}
} else {
if err := c.AddFileToRevision(ctx, revisionID, pth, opts); err != nil {
return uuid.Nil, fmt.Errorf("failed to add file %s: %w", pth, err)
}
}
}

if err := c.SealRevision(ctx, revisionID); err != nil {
return uuid.Nil, err
}

return revisionID, nil
}

// CreateRevisionFromDir uploads a directory and all its contents, returning a revision ID.
// This is a convenience method equivalent to CreateRevisionFromPaths with a single directory.
func (c *Client) CreateRevisionFromDir(ctx context.Context, dirPath string, opts UploadOptions) (RevisionID, error) {
return c.CreateRevisionFromPaths(ctx, []string{dirPath}, opts)
}

// CreateRevisionFromFile uploads a single file, returning a revision ID.
// This is a convenience method equivalent to CreateRevisionFromPaths with a single file.
func (c *Client) CreateRevisionFromFile(ctx context.Context, filePath string, opts UploadOptions) (RevisionID, error) {
return c.CreateRevisionFromPaths(ctx, []string{filePath}, opts)
}
Loading