feat: DGP-789 - group text output by Open Issues and License issues #47
Conversation
bsalomon-snyk
commented
Aug 5, 2025
bsalomon-snyk
commented
- adds unit test that compares a snapshot of a medium-severity License and high-severity vulnerability to screen output
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) ✅ code/snyk check is complete. No issues have been found. (View Details) |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| isLicense := isLicenseFinding(finding) | ||
| return !isLicense | ||
| } | ||
| } |
There was a problem hiding this comment.
Bug: Inconsistent Filter Behavior
The isNotLicenseFindingFilter function returns true when the input object is not a testapi.FindingData. This is inconsistent with other similar filter functions (e.g., isOpenFinding, isPendingFinding, isIgnoredFinding, isLicenseFindingFilter), which return false in the same scenario. Consequently, non-FindingData objects are incorrectly included in the "not license findings" filter results.
There was a problem hiding this comment.
this is by design. Licenses are called out as special, and everything else falls under "Other issues."
