Skip to content

Conversation

dotkas
Copy link
Contributor

@dotkas dotkas commented Jun 25, 2025

Pull Request Submission Checklist

  • Follows CONTRIBUTING guidelines
  • Commit messages
    are release-note ready, emphasizing
    what was changed, not how.
  • Includes detailed description of changes
  • Contains risk assessment (Low | Medium | High)
  • Highlights breaking API changes (if applicable)
  • Links to automated tests covering new functionality
  • Includes manual testing instructions (if necessary)
  • Updates relevant GitBook documentation (PR link: ___)
  • Includes product update to be announced in the next stable release notes

What does this PR do?

Where should the reviewer start?

How should this be manually tested?

What's the product update that needs to be communicated to CLI users?

Copy link
Contributor

github-actions bot commented Jun 25, 2025

Warnings
⚠️

Since the CLI is unifying on a standard and improved tooling, we're starting to migrate old-style imports and exports to ES6 ones.
A file you've modified is using either module.exports or require(). If you can, please update them to ES6 import syntax and export syntax.
Files found:

  • ts-binary-wrapper/src/common.ts
⚠️

You've modified files in src/ directory, but haven't updated anything in test folder. Is there something that could be tested?

⚠️ There are multiple commits on your branch, please squash them locally before merging!

Generated by 🚫 dangerJS against 4b25c16

Copy link

snyk-io bot commented Jun 25, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

@dotkas dotkas force-pushed the dotkas/drop-global-agent-e2e branch 3 times, most recently from 2b224e9 to 17fe0ea Compare June 30, 2025 13:00
Comment on lines -88 to -94
const proxyUrl = getProxyForUrl(baseURL);
if (proxyUrl) {
bootstrap({
environmentVariableNamespace: '',
});
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dotkas dotkas force-pushed the dotkas/drop-global-agent-e2e branch 2 times, most recently from a8140da to 35cb138 Compare August 1, 2025 10:04
@dotkas dotkas force-pushed the dotkas/drop-global-agent-e2e branch 3 times, most recently from 5db02c5 to 258eecc Compare August 1, 2025 11:11
@dotkas dotkas force-pushed the dotkas/drop-global-agent-e2e branch from 258eecc to 4b25c16 Compare August 1, 2025 11:24
@dotkas dotkas closed this Aug 14, 2025
@dotkas dotkas deleted the dotkas/drop-global-agent-e2e branch September 4, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant