fix(logging): prevent crashes when using debug and trace level logging #6041
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
are release-note ready, emphasizing
what was changed, not how.
What does this PR do?
This PR handles type conversions and errors when formatting logging timestamps, returning an empty string is definitely better than crashing the CLI run.
This also lands a change from code-client-go that removes some redundant trace logs for request bodies; and also a GAF change for limiting the size of request bodies that are logged. All of those should fix some crashes when using the CLI with debug logs and trace level enabled.
Where should the reviewer start?
Main changes here are early returning in case of type conversion error when casting the interface to a string; and I also added an early return in case the time string formatting fails, just for good measure.
How should this be manually tested?
What's the product update that needs to be communicated to CLI users?
This should fix some crashes when the CLI was used with debug and trace logging level enabled.