fix: [CLI-942] Bumping snyk-docker-plugin
#6095
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
are release-note ready, emphasizing
what was changed, not how.
What does this PR do?
This PR bumps
snyk-docker-plugin
to it's newest version, following a somewhat turbulent attempt at doing this earlier last month. Thesnyk-docker-plugin
contained some flawed logic when spawning subprocesses, and this new attempt does it following the NodeJS best practices. Namely, to not spawn subprocesses in a shell where avoidable.Where should the reviewer start?
See this PR for the details: snyk/snyk-docker-plugin#686
How should this be manually tested?
Build the CLI locally using
make build
and try to do asnyk container test node:latest
and check it succeeds correctly.What's the product update that needs to be communicated to CLI users?
N/A, implementation optimization.
Risk assessment (Low | Medium | High)?
Medium: Our acceptance tests caught the issue last time, and I believe they are fairly covering. However, there is a risk that a logical path is not covered in the acceptance tests which could trigger an issue. But in general, I believe that if
docker
is able to be run and queried on all operating systems, through this plugin, it should work as expected.