Skip to content

Conversation

dotkas
Copy link
Contributor

@dotkas dotkas commented Aug 8, 2025

Pull Request Submission Checklist

  • Follows CONTRIBUTING guidelines
  • Commit messages
    are release-note ready, emphasizing
    what was changed, not how.
  • Includes detailed description of changes
  • Contains risk assessment (Low | Medium | High)
  • Highlights breaking API changes (if applicable)
  • Links to automated tests covering new functionality
  • Includes manual testing instructions (if necessary)
  • Updates relevant GitBook documentation (PR link: ___)
  • Includes product update to be announced in the next stable release notes

What does this PR do?

This PR bumps snyk-docker-plugin to it's newest version, following a somewhat turbulent attempt at doing this earlier last month. The snyk-docker-plugin contained some flawed logic when spawning subprocesses, and this new attempt does it following the NodeJS best practices. Namely, to not spawn subprocesses in a shell where avoidable.

Where should the reviewer start?

See this PR for the details: snyk/snyk-docker-plugin#686

How should this be manually tested?

Build the CLI locally using make build and try to do a snyk container test node:latest and check it succeeds correctly.

What's the product update that needs to be communicated to CLI users?

N/A, implementation optimization.

Risk assessment (Low | Medium | High)?

Medium: Our acceptance tests caught the issue last time, and I believe they are fairly covering. However, there is a risk that a logical path is not covered in the acceptance tests which could trigger an issue. But in general, I believe that if docker is able to be run and queried on all operating systems, through this plugin, it should work as expected.

Copy link

snyk-io bot commented Aug 8, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

code/snyk check is complete. No issues have been found. (View Details)

@dotkas dotkas changed the title fix: [CLI-942] Bumping snyk-docker-plugin fix: [CLI-942] Bumping snyk-docker-plugin [wait with merge 🚨] Aug 8, 2025
@dotkas dotkas changed the title fix: [CLI-942] Bumping snyk-docker-plugin [wait with merge 🚨] fix: [CLI-942] Bumping snyk-docker-plugin Aug 8, 2025
@dotkas dotkas force-pushed the dotkas/CLI-942/roll-out-snyk-docker-plugin branch from 453e939 to bd5d6a4 Compare August 8, 2025 12:18
@dotkas dotkas marked this pull request as ready for review August 8, 2025 12:21
@dotkas dotkas requested review from a team as code owners August 8, 2025 12:21
@dotkas dotkas force-pushed the dotkas/CLI-942/roll-out-snyk-docker-plugin branch from bd5d6a4 to 7ee9e15 Compare August 10, 2025 18:24
@dotkas dotkas enabled auto-merge August 10, 2025 18:25
@dotkas dotkas merged commit 7166e55 into main Aug 11, 2025
9 checks passed
@dotkas dotkas deleted the dotkas/CLI-942/roll-out-snyk-docker-plugin branch August 11, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants